Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Issue 197023004: Add file exclusion to trunk patch creation in push-to-trunk. (Closed)

Created:
6 years, 9 months ago by Michael Achenbach
Modified:
6 years, 9 months ago
Reviewers:
Jarin
CC:
v8-dev
Visibility:
Public.

Description

Add file exclusion to trunk patch creation in push-to-trunk. This is another step towards getting rid of the bleeding edge change log file. Now it can be omitted in a follow up CL. R=jarin@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=19876

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -4 lines) Patch
M tools/push-to-trunk/git_recipes.py View 1 chunk +5 lines, -2 lines 1 comment Download
M tools/push-to-trunk/test_scripts.py View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Michael Achenbach
PTAL https://codereview.chromium.org/197023004/diff/1/tools/push-to-trunk/git_recipes.py File tools/push-to-trunk/git_recipes.py (right): https://codereview.chromium.org/197023004/diff/1/tools/push-to-trunk/git_recipes.py#newcode135 tools/push-to-trunk/git_recipes.py:135: I hope this approach has no potential for ...
6 years, 9 months ago (2014-03-12 15:35:06 UTC) #1
Jarin
lgtm, although I am not sure how the change to GitDiff relates to the change ...
6 years, 9 months ago (2014-03-13 06:16:18 UTC) #2
Michael Achenbach
On 2014/03/13 06:16:18, jarin wrote: > lgtm, although I am not sure how the change ...
6 years, 9 months ago (2014-03-13 07:53:21 UTC) #3
Michael Achenbach
6 years, 9 months ago (2014-03-13 07:57:13 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r19876 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698