Chromium Code Reviews

Issue 197023002: Fix a race in initialization of timezone cache in platform-win32. (Closed)

Created:
6 years, 9 months ago by ulan
Modified:
6 years, 9 months ago
Reviewers:
jamesr, jochen (gone - plz use gerrit)
CC:
v8-dev
Visibility:
Public.

Description

Fix a race in initialization of timezone cache in platform-win32. This allocates a timezone cache per isolate. BUG= R=jochen@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=19943

Patch Set 1 #

Patch Set 2 : Fixes #

Patch Set 3 : Fix CE #

Unified diffs Side-by-side diffs Stats (+188 lines, -161 lines)
M src/date.h View 4 chunks +10 lines, -5 lines 0 comments
M src/date.cc View 1 chunk +1 line, -1 line 0 comments
M src/platform.h View 2 chunks +10 lines, -5 lines 0 comments
M src/platform-cygwin.cc View 2 chunks +2 lines, -2 lines 0 comments
M src/platform-freebsd.cc View 2 chunks +2 lines, -2 lines 0 comments
M src/platform-linux.cc View 2 chunks +2 lines, -2 lines 0 comments
M src/platform-macos.cc View 2 chunks +2 lines, -2 lines 0 comments
M src/platform-openbsd.cc View 2 chunks +2 lines, -2 lines 0 comments
M src/platform-posix.cc View 2 chunks +19 lines, -4 lines 0 comments
M src/platform-qnx.cc View 2 chunks +2 lines, -2 lines 0 comments
M src/platform-solaris.cc View 2 chunks +2 lines, -2 lines 0 comments
M src/platform-win32.cc View 8 chunks +132 lines, -130 lines 0 comments
M src/runtime.cc View 1 chunk +2 lines, -2 lines 0 comments

Messages

Total messages: 3 (0 generated)
ulan
PTAL
6 years, 9 months ago (2014-03-12 10:09:07 UTC) #1
jochen (gone - plz use gerrit)
lgtm
6 years, 9 months ago (2014-03-12 10:58:09 UTC) #2
ulan
6 years, 9 months ago (2014-03-14 15:20:07 UTC) #3
Message was sent while issue was closed.
Committed patchset #3 manually as r19943 (presubmit successful).

Powered by Google App Engine