Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 197023: This CL changes the CookieStore obect to be a refcounted object to get a bett... (Closed)

Created:
11 years, 3 months ago by ananta
Modified:
9 years, 6 months ago
Reviewers:
eroman
CC:
chromium-reviews_googlegroups.com, darin (slow to review), brettw, willchan no longer on Chromium, Paweł Hajdan Jr.
Visibility:
Public.

Description

This CL changes the CookieStore obect to be a refcounted object to get a better handle on its lifetime as there are cases where this object is handed out to URLRequestContext instances which outlive the URLRequestContext object which created it. Partial fix for http://code.google.com/p/chromium/issues/detail?id=15289 Bug=15289 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=25558

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Total comments: 12

Patch Set 6 : '' #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+281 lines, -284 lines) Patch
M chrome/browser/automation/automation_profile_impl.h View 5 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/automation/automation_profile_impl.cc View 5 1 chunk +5 lines, -4 lines 0 comments Download
M chrome/browser/gtk/options/cookies_view_unittest.cc View 3 4 5 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/net/chrome_url_request_context.h View 3 4 5 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/net/chrome_url_request_context.cc View 2 3 4 5 3 chunks +12 lines, -19 lines 0 comments Download
M chrome/browser/sync/glue/http_bridge.cc View 3 4 5 1 chunk +0 lines, -1 line 0 comments Download
M net/base/cookie_monster.h View 3 4 5 2 chunks +6 lines, -2 lines 1 comment Download
M net/base/cookie_monster_unittest.cc View 1 2 3 4 5 10 chunks +252 lines, -247 lines 0 comments Download
M net/base/cookie_store.h View 1 2 3 4 5 2 chunks +3 lines, -2 lines 0 comments Download
M net/url_request/url_request_context.h View 1 2 3 4 5 2 chunks +2 lines, -2 lines 0 comments Download
M net/url_request/url_request_unittest.cc View 1 2 3 4 5 1 chunk +0 lines, -1 line 0 comments Download
M webkit/tools/test_shell/test_shell_request_context.cc View 4 5 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
ananta
11 years, 3 months ago (2009-09-04 05:29:14 UTC) #1
ananta
On 2009/09/04 05:29:14, ananta wrote: > Please hold off on the review for a bit. ...
11 years, 3 months ago (2009-09-04 06:14:19 UTC) #2
ananta
On 2009/09/04 06:14:19, ananta wrote: > On 2009/09/04 05:29:14, ananta wrote: > > > > ...
11 years, 3 months ago (2009-09-04 07:48:24 UTC) #3
eroman
http://codereview.chromium.org/197023/diff/5013/5024 File chrome/browser/automation/automation_profile_impl.cc (right): http://codereview.chromium.org/197023/diff/5013/5024#newcode103 Line 103: net::CookieStore* original_cookie_store_; Shouldn't this be a scoped_refptr? http://codereview.chromium.org/197023/diff/5013/5022 ...
11 years, 3 months ago (2009-09-04 22:38:57 UTC) #4
ananta
http://codereview.chromium.org/197023/diff/5013/5024 File chrome/browser/automation/automation_profile_impl.cc (right): http://codereview.chromium.org/197023/diff/5013/5024#newcode103 Line 103: net::CookieStore* original_cookie_store_; On 2009/09/04 22:38:59, eroman wrote: > ...
11 years, 3 months ago (2009-09-04 23:08:56 UTC) #5
eroman
11 years, 3 months ago (2009-09-04 23:13:24 UTC) #6
lgtm!

http://codereview.chromium.org/197023/diff/4010/3021
File net/base/cookie_monster.h (right):

http://codereview.chromium.org/197023/diff/4010/3021#newcode370
Line 370: typedef
base::RefCountedThreadSafe<CookieMonster::PersistentCookieStore>
hehe.

Powered by Google App Engine
This is Rietveld 408576698