Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1970203002: [Smart Lock] Remove misleading dcheck from AccountChooser. (Closed)

Created:
4 years, 7 months ago by melandory
Modified:
4 years, 7 months ago
CC:
chromium-reviews, gcasto+watchlist_chromium.org, vabr+watchlistpasswordmanager_chromium.org, mkwst+watchlist-passwords_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Smart Lock] Remove misleading dcheck from AccountChooser. BUG=611374 Committed: https://crrev.com/c259b268ec46eb0268222e37d7d1da8f93a2b46a Cr-Commit-Position: refs/heads/master@{#393506}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M chrome/browser/password_manager/account_chooser_dialog_android.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
melandory
PTAL, thanks. P.S. It seems that this check was never executed, because AccountChooserDialog always receives ...
4 years, 7 months ago (2016-05-12 14:01:27 UTC) #3
vabr (Chromium)
LGTM. Thanks for the investigating, I'm curious to hear what you find. Cheers, Vaclav
4 years, 7 months ago (2016-05-12 14:07:22 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1970203002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1970203002/20001
4 years, 7 months ago (2016-05-13 11:58:32 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 7 months ago (2016-05-13 12:26:58 UTC) #8
commit-bot: I haz the power
4 years, 7 months ago (2016-05-13 12:28:45 UTC) #10
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/c259b268ec46eb0268222e37d7d1da8f93a2b46a
Cr-Commit-Position: refs/heads/master@{#393506}

Powered by Google App Engine
This is Rietveld 408576698