Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(750)

Issue 1970193003: Revert of Add V8.Execute histogram to measure time spent executing JS code. (Closed)

Created:
4 years, 7 months ago by Michael Hablich
Modified:
4 years, 7 months ago
Reviewers:
Camillo Bruni, rmcilroy
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Add V8.Execute histogram to measure time spent executing JS code. (patchset #1 id:1 of https://codereview.chromium.org/1974003002/ ) Reason for revert: Blocks roll https://codereview.chromium.org/1972303002/ Repro: - build chromium with this CL - out/Default/content_browsertests --gtest_filter=AccessibilityHitTestingBrowserTest.HitTestingInIframes Original issue's description: > Add V8.Execute histogram to measure time spent executing JS code. > > Adds a V8.Execute histogram to measure the amount of time spent executing > JS code. > > BUG=v8:4865 > LOG=N > > Committed: https://crrev.com/e8f5a2723cf54576b84322ac2ee6ef7abc9df056 > Cr-Commit-Position: refs/heads/master@{#36217} TBR=cbruni@chromium.org,rmcilroy@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4865 Committed: https://crrev.com/fff4301f8a0ac9c9bdb6f3b8ab6d9d7d44c64d5a Cr-Commit-Position: refs/heads/master@{#36234}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -47 lines) Patch
M src/api.cc View 5 chunks +0 lines, -5 lines 0 comments Download
M src/counters.h View 1 chunk +40 lines, -42 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Michael Hablich
Created Revert of Add V8.Execute histogram to measure time spent executing JS code.
4 years, 7 months ago (2016-05-13 11:16:22 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1970193003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1970193003/1
4 years, 7 months ago (2016-05-13 11:16:29 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-13 11:16:44 UTC) #4
commit-bot: I haz the power
4 years, 7 months ago (2016-05-13 11:17:31 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fff4301f8a0ac9c9bdb6f3b8ab6d9d7d44c64d5a
Cr-Commit-Position: refs/heads/master@{#36234}

Powered by Google App Engine
This is Rietveld 408576698