src/compiler.cc - Issue 1970193002: [compiler] Avoid passing CompilationInfo to profiler.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/compiler.cc

Issue 1970193002: [compiler] Avoid passing CompilationInfo to profiler. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@local_cleanup-compiler-sidechannel-2

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/compiler.cc

diff --git a/src/compiler.cc b/src/compiler.cc

index bdf20a12c914da22f57f0f50985bd73a908858b3..a3c42c411dfdab60f714974368063087699b25b2 100644

--- a/src/compiler.cc

+++ b/src/compiler.cc

@@ -400,7 +400,7 @@ void RecordFunctionCompilation(Logger::LogEventsAndTags tag,

: info->isolate()->heap()->empty_string();

Logger::LogEventsAndTags log_tag = Logger::ToNativeByScript(tag, *script);

PROFILE(info->isolate(),

- CodeCreateEvent(log_tag, *abstract_code, *shared, info, script_name,

+ CodeCreateEvent(log_tag, *abstract_code, *shared, script_name,

line_num, column_num));

}

« no previous file with comments | « no previous file | src/compiler/ast-graph-builder.h » ('j') | src/compiler/ast-graph-builder.h » ('J')