Don't use canCollapseAnonymousBlockChild() to determine whether to truncate text.

Don't use canCollapseAnonymousBlockChild() to determine whether to truncate text.

Doing that happened to do exactly what we wanted, but that seems like a rather
haphazard way of determining it.

We want to truncate text for block containers [1]. That's LayoutBlockFlow.
Additionally, in Blink, HTML button is implemented using LayoutFlexibleBox
(although the web insists that it too is a block container).

[1] https://www.w3.org/TR/css-ui-3/#propdef-text-overflow

Rather than manually testing for isLayoutBlockFlow() || isLayoutButton()
directly when deciding to truncate or not, I went and hijacked
canHaveFirstLineOrFirstLetterStyle(), and renamed it to behavesLikeBlockContainer().

Committed: https://crrev.com/d08a9f0ef4a3fc48a719433f2ebe4eb53dcf186a
Cr-Commit-Position: refs/heads/master@{#393354}

[mstensho (USE GERRIT), 2016-05-12 18:40:05]

Description was changed from

==========
Don't use canCollapseAnonymousBlockChild() to determine whether to truncate
text.

Doing that happened to do exactly what we wanted, but that's a rather haphazard
way of determining it.

*** DO NOT LAND *** This CL currently causes breakage for buttons with text
truncations. Hopefully we'll find some failing tests now, or I'll have to
create one myself.
==========

to

==========
Don't use canCollapseAnonymousBlockChild() to determine whether to truncate
text.

Doing that happened to do exactly what we wanted, but that seems like a rather
haphazard way of determining it.

We want to truncate text for block containers [1]. That's LayoutBlockFlow.
Additionally, in Blink, HTML button is implemented using LayoutFlexibleBox
(although the web insists that it too is a block container).

[1] https://www.w3.org/TR/css-ui-3/#propdef-text-overflow

Rather than manually testing for isLayoutBlockFlow() || isLayoutButton()
directly when deciding to truncate or not, I went and hijacked
canHaveFirstLineOrFirstLetterStyle(), and renamed it to
behavesLikeBlockContainer().
==========

[mstensho (USE GERRIT), 2016-05-12 18:42:49]

mstensho@opera.com changed reviewers:
+ eae@chromium.org, szager@chromium.org, wkorman@chromium.org

[mstensho (USE GERRIT), 2016-05-12 18:42:50]

No big deal, you say?

Well, it is to me, because I wanna kill canCollapseAnonymousBlockChild()! :)

[eae, 2016-05-12 18:45:55]

LGTM

As long as you agree to mow the lawn every now and then.

[eae, 2016-05-12 18:46:03]

The CQ bit was checked by eae@chromium.org

[commit-bot: I haz the power, 2016-05-12 18:46:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1970183002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1970183002/40001

[commit-bot: I haz the power, 2016-05-12 20:05:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-12 20:05:42]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[mstensho (USE GERRIT), 2016-05-12 20:26:20]

The CQ bit was checked by mstensho@opera.com

[commit-bot: I haz the power, 2016-05-12 20:26:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1970183002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1970183002/40001

[commit-bot: I haz the power, 2016-05-12 21:09:53]

Description was changed from

==========
Don't use canCollapseAnonymousBlockChild() to determine whether to truncate
text.

Doing that happened to do exactly what we wanted, but that seems like a rather
haphazard way of determining it.

We want to truncate text for block containers [1]. That's LayoutBlockFlow.
Additionally, in Blink, HTML button is implemented using LayoutFlexibleBox
(although the web insists that it too is a block container).

[1] https://www.w3.org/TR/css-ui-3/#propdef-text-overflow

Rather than manually testing for isLayoutBlockFlow() || isLayoutButton()
directly when deciding to truncate or not, I went and hijacked
canHaveFirstLineOrFirstLetterStyle(), and renamed it to
behavesLikeBlockContainer().
==========

to

==========
Don't use canCollapseAnonymousBlockChild() to determine whether to truncate
text.

Doing that happened to do exactly what we wanted, but that seems like a rather
haphazard way of determining it.

We want to truncate text for block containers [1]. That's LayoutBlockFlow.
Additionally, in Blink, HTML button is implemented using LayoutFlexibleBox
(although the web insists that it too is a block container).

[1] https://www.w3.org/TR/css-ui-3/#propdef-text-overflow

Rather than manually testing for isLayoutBlockFlow() || isLayoutButton()
directly when deciding to truncate or not, I went and hijacked
canHaveFirstLineOrFirstLetterStyle(), and renamed it to
behavesLikeBlockContainer().
==========

[commit-bot: I haz the power, 2016-05-12 21:09:54]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-05-12 21:11:35]

Description was changed from

==========
Don't use canCollapseAnonymousBlockChild() to determine whether to truncate
text.

Doing that happened to do exactly what we wanted, but that seems like a rather
haphazard way of determining it.

We want to truncate text for block containers [1]. That's LayoutBlockFlow.
Additionally, in Blink, HTML button is implemented using LayoutFlexibleBox
(although the web insists that it too is a block container).

[1] https://www.w3.org/TR/css-ui-3/#propdef-text-overflow

Rather than manually testing for isLayoutBlockFlow() || isLayoutButton()
directly when deciding to truncate or not, I went and hijacked
canHaveFirstLineOrFirstLetterStyle(), and renamed it to
behavesLikeBlockContainer().
==========

to

==========
Don't use canCollapseAnonymousBlockChild() to determine whether to truncate
text.

Doing that happened to do exactly what we wanted, but that seems like a rather
haphazard way of determining it.

We want to truncate text for block containers [1]. That's LayoutBlockFlow.
Additionally, in Blink, HTML button is implemented using LayoutFlexibleBox
(although the web insists that it too is a block container).

[1] https://www.w3.org/TR/css-ui-3/#propdef-text-overflow

Rather than manually testing for isLayoutBlockFlow() || isLayoutButton()
directly when deciding to truncate or not, I went and hijacked
canHaveFirstLineOrFirstLetterStyle(), and renamed it to
behavesLikeBlockContainer().

Committed: https://crrev.com/d08a9f0ef4a3fc48a719433f2ebe4eb53dcf186a
Cr-Commit-Position: refs/heads/master@{#393354}
==========

[commit-bot: I haz the power, 2016-05-12 21:11:36]

Patchset 3 (id:??) landed as
https://crrev.com/d08a9f0ef4a3fc48a719433f2ebe4eb53dcf186a
Cr-Commit-Position: refs/heads/master@{#393354}