Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Side by Side Diff: ios/chrome/browser/experimental_flags.mm

Issue 1970163002: Adding flags and finch trial for the removal of All Bookmarks view. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « ios/chrome/browser/experimental_flags.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // This file can be empty. Its purpose is to contain the relatively short lived 5 // This file can be empty. Its purpose is to contain the relatively short lived
6 // definitions required for experimental flags. 6 // definitions required for experimental flags.
7 7
8 #include "ios/chrome/browser/experimental_flags.h" 8 #include "ios/chrome/browser/experimental_flags.h"
9 9
10 #include <dispatch/dispatch.h> 10 #include <dispatch/dispatch.h>
(...skipping 84 matching lines...) Expand 10 before | Expand all | Expand 10 after
95 // Check if the finch experiment is turned on. 95 // Check if the finch experiment is turned on.
96 std::string group_name = base::FieldTrialList::FindFullName("IOSTabSwitcher"); 96 std::string group_name = base::FieldTrialList::FindFullName("IOSTabSwitcher");
97 return base::StartsWith(group_name, "Enabled", 97 return base::StartsWith(group_name, "Enabled",
98 base::CompareCase::INSENSITIVE_ASCII); 98 base::CompareCase::INSENSITIVE_ASCII);
99 } 99 }
100 100
101 bool IsReadingListEnabled() { 101 bool IsReadingListEnabled() {
102 return [[NSUserDefaults standardUserDefaults] boolForKey:kEnableReadingList]; 102 return [[NSUserDefaults standardUserDefaults] boolForKey:kEnableReadingList];
103 } 103 }
104 104
105 bool IsAllBookmarksEnabled() {
106 base::CommandLine* command_line = base::CommandLine::ForCurrentProcess();
107 if (command_line->HasSwitch(switches::kEnableAllBookmarksView)) {
108 return true;
109 } else if (command_line->HasSwitch(switches::kDisableAllBookmarksView)) {
110 return false;
111 }
112
113 // Check if the finch experiment is turned on. Flag is off by default.
114 std::string group_name =
115 base::FieldTrialList::FindFullName("RemoveAllBookmarks");
116
117 return base::StartsWith(group_name, "Enabled",
118 base::CompareCase::INSENSITIVE_ASCII);
119 }
120
105 } // namespace experimental_flags 121 } // namespace experimental_flags
OLDNEW
« no previous file with comments | « ios/chrome/browser/experimental_flags.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698