Http Cache: Add support for resuming downloading a...

Http Cache: Add support for resuming downloading a
resource after the original request was interrupted.

BUG=8995
TEST=unittests



Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=25551

[darin (slow to review), 2009-09-04 21:46:33]

We should extend view-cache sometime to make it show all of the meta data
values.

http://codereview.chromium.org/197016/diff/1/3
File net/http/http_cache.cc (right):

http://codereview.chromium.org/197016/diff/1/3#newcode1717
Line 1717: *request_truncated = flags & RESPONSE_INFO_TRUNCATED ? true : false;
nit: ()'s around the boolean expression would be nice for readability.

http://codereview.chromium.org/197016/diff/1/3#newcode1994
Line 1994: // Assume that this is not a successful write if we are not
cancelling it.
can you write this comment without the double negative?  i had trouble parsing
it.

http://codereview.chromium.org/197016/diff/1/3#newcode1995
Line 1995: DoneWritingToEntry(entry, cancel);
this function is pretty confusing to me since the second parameter to
DoneWritingToEntry is success, but here we are passing a variable named cancel. 
generally, i don't think of cancel as synonymous with success!

maybe it would help to define a success local variable?  and then add a comment
explaining why cancellation is a condition for success.

http://codereview.chromium.org/197016/diff/1/6
File net/http/http_cache.h (right):

http://codereview.chromium.org/197016/diff/1/6#newcode104
Line 104: bool* request_truncated);
nit: wouldn't response_truncated be a better name?

http://codereview.chromium.org/197016/diff/1/2
File net/http/http_cache_unittest.cc (right):

http://codereview.chromium.org/197016/diff/1/2#newcode2265
Line 2265: c->result = c->callback.WaitForResult();
nit: indent only 2 spaces

http://codereview.chromium.org/197016/diff/1/2#newcode2293
Line 2293: rv = c->callback.WaitForResult();
nit: indent only 2 spaces

[rvargas (doing something else), 2009-09-04 22:57:25]

Thanks,

Please take another look.

[darin (slow to review), 2009-09-04 23:30:31]

LGTM