Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1435)

Side by Side Diff: chrome/test/data/extensions/api_test/automation/tests/tabs/close_tab.js

Issue 1970153003: Completely detach removed nodes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix test. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/renderer/resources/extensions/automation/automation_node.js ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 var allTests = [ 5 var allTests = [
6 function testCloseTab() { 6 function testCloseTab() {
7 getUrlFromConfig('index.html', function(url) { 7 getUrlFromConfig('index.html', function(url) {
8 chrome.tabs.create({'url': url}, function(tab) { 8 chrome.tabs.create({'url': url}, function(tab) {
9 chrome.automation.getTree(function(rootNode) { 9 chrome.automation.getTree(function(rootNode) {
10 var button = rootNode.find({role: 'button'});
11 assertEq(rootNode, button.root);
12
10 rootNode.addEventListener(EventType.destroyed, function() { 13 rootNode.addEventListener(EventType.destroyed, function() {
11 // Poll until the root node doesn't have a role anymore 14 // Poll until the root node doesn't have a role anymore
12 // indicating that it really did get cleaned up. 15 // indicating that it really did get cleaned up.
13 function checkSuccess() { 16 function checkSuccess() {
14 if (rootNode.role === undefined) 17 if (rootNode.role === undefined && rootNode.root === null) {
18 assertEq(null, button.root);
15 chrome.test.succeed(); 19 chrome.test.succeed();
20 }
16 else 21 else
17 window.setTimeout(checkSuccess, 10); 22 window.setTimeout(checkSuccess, 10);
18 } 23 }
19 checkSuccess(); 24 checkSuccess();
20 }); 25 });
21 chrome.tabs.remove(tab.id); 26 chrome.tabs.remove(tab.id);
22 }); 27 });
23 }); 28 });
24 }); 29 });
25 } 30 }
26 ] 31 ]
27 chrome.test.runTests(allTests); 32 chrome.test.runTests(allTests);
OLDNEW
« no previous file with comments | « chrome/renderer/resources/extensions/automation/automation_node.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698