Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(701)

Side by Side Diff: chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js

Issue 1970153003: Completely detach removed nodes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix test. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 /** 5 /**
6 * @fileoverview Provides output services for ChromeVox. 6 * @fileoverview Provides output services for ChromeVox.
7 */ 7 */
8 8
9 goog.provide('Output'); 9 goog.provide('Output');
10 goog.provide('Output.EventType'); 10 goog.provide('Output.EventType');
(...skipping 895 matching lines...) Expand 10 before | Expand all | Expand 10 after
906 /** 906 /**
907 * Renders the given range using optional context previous range and event 907 * Renders the given range using optional context previous range and event
908 * type. 908 * type.
909 * @param {!cursors.Range} range 909 * @param {!cursors.Range} range
910 * @param {cursors.Range} prevRange 910 * @param {cursors.Range} prevRange
911 * @param {EventType|Output.EventType} type 911 * @param {EventType|Output.EventType} type
912 * @param {!Array<Spannable>} buff Buffer to receive rendered output. 912 * @param {!Array<Spannable>} buff Buffer to receive rendered output.
913 * @private 913 * @private
914 */ 914 */
915 render_: function(range, prevRange, type, buff) { 915 render_: function(range, prevRange, type, buff) {
916 if (prevRange && !prevRange.isValid())
917 prevRange = null;
918
916 if (range.isSubNode()) 919 if (range.isSubNode())
917 this.subNode_(range, prevRange, type, buff); 920 this.subNode_(range, prevRange, type, buff);
918 else 921 else
919 this.range_(range, prevRange, type, buff); 922 this.range_(range, prevRange, type, buff);
920 }, 923 },
921 924
922 /** 925 /**
923 * Format the node given the format specifier. 926 * Format the node given the format specifier.
924 * @param {AutomationNode} node 927 * @param {AutomationNode} node
925 * @param {string|!Object} format The output format either specified as an 928 * @param {string|!Object} format The output format either specified as an
(...skipping 646 matching lines...) Expand 10 before | Expand all | Expand 10 after
1572 break; 1575 break;
1573 } 1576 }
1574 earconFinder = earconFinder.parent; 1577 earconFinder = earconFinder.parent;
1575 } 1578 }
1576 } 1579 }
1577 return null; 1580 return null;
1578 } 1581 }
1579 }; 1582 };
1580 1583
1581 }); // goog.scope 1584 }); // goog.scope
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698