Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(481)

Issue 197013010: Enable debug fission for Chrome debug builds. (Closed)

Created:
6 years, 9 months ago by mithro-old
Modified:
6 years, 8 months ago
CC:
chromium-reviews, Jeffrey Yasskin, echristo.google, cmtice, Han Shen, yunlian, vapier, bjanakiraman1, llozano, brettw
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

This change helps with two significant problems with Chrome debug builds, * Slow link times. * Slow gdb startup times. Lots more detailed information at http://gcc.gnu.org/wiki/DebugFission Overall, this improves linking speed of debug Chrome builds on Linux by ~12% and speeds up gdb by around 30%. This requires a objcopy with --extract-dwo object (binutils newer then 2.22.52.0.4 // 2.23). Ubuntu Precise only comes with 2.22 BUG=352046 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=257424

Patch Set 1 #

Patch Set 2 : Just modify compiler_version instead of seperate tool. #

Total comments: 5

Patch Set 3 : Rebase onto master. #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -10 lines) Patch
M build/common.gypi View 1 2 2 chunks +9 lines, -0 lines 1 comment Download
M build/compiler_version.py View 1 1 chunk +34 lines, -10 lines 1 comment Download

Messages

Total messages: 27 (0 generated)
mithro-old
Heyo! Here are is the patches for Chrome related to enabling debug fission change.
6 years, 9 months ago (2014-03-16 10:49:52 UTC) #1
mithro-old
Heyo! Here are is the patches for Chrome related to enabling debug fission change. See ...
6 years, 9 months ago (2014-03-16 10:52:05 UTC) #2
Nico
https://codereview.chromium.org/197013010/diff/20001/build/common.gypi File build/common.gypi (right): https://codereview.chromium.org/197013010/diff/20001/build/common.gypi#newcode3093 build/common.gypi:3093: 'ldflags': ['-Wl,--gdb-index'], Is there some way we can get ...
6 years, 9 months ago (2014-03-17 09:07:38 UTC) #3
mithro-old
On 2014/03/17 09:07:38, Nico (on GMT time Mar 15 - 24) wrote: > https://codereview.chromium.org/197013010/diff/20001/build/common.gypi > ...
6 years, 9 months ago (2014-03-17 09:22:32 UTC) #4
Nico
Cool, lgtm then. https://codereview.chromium.org/197013010/diff/20001/build/compiler_version.py File build/compiler_version.py (right): https://codereview.chromium.org/197013010/diff/20001/build/compiler_version.py#newcode33 build/compiler_version.py:33: version_re = re.compile(r"GNU [^ ]+ \(.*\) ...
6 years, 9 months ago (2014-03-17 09:42:39 UTC) #5
Nico
https://codereview.chromium.org/197013010/diff/20001/build/compiler_version.py File build/compiler_version.py (right): https://codereview.chromium.org/197013010/diff/20001/build/compiler_version.py#newcode33 build/compiler_version.py:33: version_re = re.compile(r"GNU [^ ]+ \(.*\) (\d+).(\d+)") On 2014/03/17 ...
6 years, 9 months ago (2014-03-17 09:42:53 UTC) #6
Nico
Actually: Does this do the right thing for cross builds (say android), if only the ...
6 years, 9 months ago (2014-03-17 10:14:40 UTC) #7
mithro-old
On 2014/03/17 10:14:40, Nico (on GMT time Mar 15 - 24) wrote: > Actually: Does ...
6 years, 9 months ago (2014-03-17 10:36:20 UTC) #8
Nico
On Mon, Mar 17, 2014 at 10:36 AM, <mithro@mithis.com> wrote: > On 2014/03/17 10:14:40, Nico ...
6 years, 9 months ago (2014-03-17 10:53:05 UTC) #9
mithro-old
The CQ bit was checked by mithro@mithis.com
6 years, 9 months ago (2014-03-17 11:28:34 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mithro@mithis.com/197013010/40001
6 years, 9 months ago (2014-03-17 11:28:43 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-17 12:38:08 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on mac_chromium_rel
6 years, 9 months ago (2014-03-17 12:38:09 UTC) #13
mithro-old
The CQ bit was checked by mithro@mithis.com
6 years, 9 months ago (2014-03-17 12:47:44 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mithro@mithis.com/197013010/40001
6 years, 9 months ago (2014-03-17 12:48:02 UTC) #15
commit-bot: I haz the power
Change committed as 257424
6 years, 9 months ago (2014-03-17 14:11:23 UTC) #16
Lei Zhang
https://codereview.chromium.org/197013010/diff/40001/build/compiler_version.py File build/compiler_version.py (right): https://codereview.chromium.org/197013010/diff/40001/build/compiler_version.py#newcode58 build/compiler_version.py:58: print "Unknown arguments!" Probably should return 1 in this ...
6 years, 9 months ago (2014-03-17 18:43:53 UTC) #17
Inactive
Starting today, I am getting linking errors on Linux Desktop, could it be related to ...
6 years, 9 months ago (2014-03-17 18:57:28 UTC) #18
Inactive
On 2014/03/17 18:57:28, Chris Dumez wrote: > Starting today, I am getting linking errors on ...
6 years, 9 months ago (2014-03-17 18:59:17 UTC) #19
Lei Zhang
On 2014/03/17 18:59:17, Chris Dumez wrote: > On 2014/03/17 18:57:28, Chris Dumez wrote: > > ...
6 years, 9 months ago (2014-03-17 19:01:44 UTC) #20
Nico
Chris: No, that's from r257419 (see http://svnsearch.org/svnsearch/repos/CHROMIUM/search?author=jochen@chromium.orgfor a few follow-ups). On Mon, Mar 17, 2014 ...
6 years, 9 months ago (2014-03-18 00:16:48 UTC) #21
Adam Goode
On 2014/03/18 00:16:48, Nico (on GMT time Mar 15 - 24) wrote: > Chris: No, ...
6 years, 9 months ago (2014-03-18 03:18:39 UTC) #22
Daniel Bratell
The commit message says "Ubuntu Precise only comes with 2.23". I think you meant 2.22, ...
6 years, 9 months ago (2014-03-18 10:06:03 UTC) #23
mithro-old
Sorry, yes you are correct. I updated my local commit message but forgot to update ...
6 years, 9 months ago (2014-03-18 10:13:56 UTC) #24
ostap
https://codereview.chromium.org/197013010/diff/40001/build/common.gypi File build/common.gypi (right): https://codereview.chromium.org/197013010/diff/40001/build/common.gypi#newcode3092 build/common.gypi:3092: ['linux_use_gold_flags==1 and (clang==1 or gcc_version>=47) and binutils_version>=223', { I ...
6 years, 9 months ago (2014-03-18 16:00:05 UTC) #25
Nico
A fix for the 4.7 problem is in the CQ here: https://codereview.chromium.org/203133003/ On Tue, Mar ...
6 years, 9 months ago (2014-03-18 16:01:10 UTC) #26
Nico
6 years, 8 months ago (2014-04-10 18:15:38 UTC) #27
Message was sent while issue was closed.
(re cl description: Always include the "title" line as first line in the
description too, as only the description makes it into the commit message. The
commit message is now missing "Enable debug fission for Chrome debug builds."
which makes it sound a bit incomplete.)

Powered by Google App Engine
This is Rietveld 408576698