Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1357)

Unified Diff: chrome/browser/download/download_dir_policy_handler_unittest.cc

Issue 197013007: Set drive as the default download folder (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixes even more nits Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/download/download_dir_policy_handler_unittest.cc
diff --git a/chrome/browser/download/download_dir_policy_handler_unittest.cc b/chrome/browser/download/download_dir_policy_handler_unittest.cc
index 1b5e8b7a9a617fb12dcb0b5a904aa1a93a2a6d74..549f58e59bc22d910d5c5906468b7d7d902e0959 100644
--- a/chrome/browser/download/download_dir_policy_handler_unittest.cc
+++ b/chrome/browser/download/download_dir_policy_handler_unittest.cc
@@ -2,25 +2,69 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
+#include <string>
+
+#include "base/compiler_specific.h"
+#include "base/files/file_path.h"
#include "base/values.h"
#include "chrome/browser/download/download_dir_policy_handler.h"
#include "chrome/browser/download/download_prefs.h"
#include "chrome/common/pref_names.h"
+#include "components/policy/core/browser/configuration_policy_handler_parameters.h"
#include "components/policy/core/browser/configuration_policy_pref_store.h"
#include "components/policy/core/browser/configuration_policy_pref_store_test.h"
+#include "components/policy/core/common/policy_details.h"
#include "components/policy/core/common/policy_map.h"
+#include "components/policy/core/common/policy_types.h"
#include "policy/policy_constants.h"
+#if defined(OS_CHROMEOS)
+#include "chrome/browser/chromeos/drive/file_system_util.h"
+#endif
+
+namespace {
+
+const char* kUserIDHash = "deadbeef";
+
+#if defined(OS_CHROMEOS)
+const char* kDriveNamePolicyVariableName = "${google_drive}";
+const base::FilePath::CharType* kRootRelativeToDriveMount =
+ FILE_PATH_LITERAL("root");
+const char* kRelativeToDriveRoot = "/home/";
+
+std::string GetExpectedDownloadDirectory() {
+ return drive::util::GetDriveMountPointPathForUserIdHash(kUserIDHash)
+ .Append(kRootRelativeToDriveMount)
+ .value();
+}
+
+#endif
+
+} // namespace
+
class DownloadDirPolicyHandlerTest
: public policy::ConfigurationPolicyPrefStoreTest {
public:
virtual void SetUp() OVERRIDE {
+ recommended_store = new policy::ConfigurationPolicyPrefStore(
+ policy_service_.get(),
+ &handler_list_,
+ policy::POLICY_LEVEL_RECOMMENDED);
handler_list_.AddHandler(
make_scoped_ptr<policy::ConfigurationPolicyHandler>(
new DownloadDirPolicyHandler));
}
+
+ virtual void PopulatePolicyHandlerParameters(
+ policy::PolicyHandlerParameters* parameters) OVERRIDE {
+ parameters->user_id_hash = kUserIDHash;
+ }
+
+ protected:
+ scoped_refptr<policy::ConfigurationPolicyPrefStore> recommended_store;
bartfab (slow) 2014/03/14 16:55:40 Nit: Add trailing underscore.
};
+#if !defined(OS_CHROMEOS)
TEST_F(DownloadDirPolicyHandlerTest, SetDownloadDirectory) {
policy::PolicyMap policy;
EXPECT_FALSE(store_->GetValue(prefs::kPromptForDownload, NULL));
@@ -40,3 +84,47 @@ TEST_F(DownloadDirPolicyHandlerTest, SetDownloadDirectory) {
ASSERT_TRUE(result);
EXPECT_FALSE(prompt_for_download);
}
+#endif
+
+#if defined(OS_CHROMEOS)
+TEST_F(DownloadDirPolicyHandlerTest, SetDownloadToDrive) {
+ EXPECT_FALSE(store_->GetValue(prefs::kPromptForDownload, NULL));
+
+ policy::PolicyMap policy;
+ policy.Set(policy::key::kDownloadDirectory,
+ policy::POLICY_LEVEL_MANDATORY,
+ policy::POLICY_SCOPE_USER,
+ new base::StringValue(kDriveNamePolicyVariableName),
+ NULL);
+ UpdateProviderPolicy(policy);
+
+ const base::Value* value = NULL;
+ bool prompt_for_download;
+ EXPECT_TRUE(store_->GetValue(prefs::kPromptForDownload, &value));
+ EXPECT_TRUE(value);
+ EXPECT_TRUE(value->GetAsBoolean(&prompt_for_download));
+ EXPECT_FALSE(prompt_for_download);
+
+ std::string download_directory;
+ EXPECT_TRUE(store_->GetValue(prefs::kDownloadDefaultDirectory, &value));
+ EXPECT_TRUE(value);
+ EXPECT_TRUE(value->GetAsString(&download_directory));
+ EXPECT_EQ(GetExpectedDownloadDirectory(), download_directory);
+
+ policy.Set(policy::key::kDownloadDirectory,
+ policy::POLICY_LEVEL_RECOMMENDED,
+ policy::POLICY_SCOPE_USER,
+ new base::StringValue(std::string(kDriveNamePolicyVariableName) +
+ kRelativeToDriveRoot),
+ NULL);
+ UpdateProviderPolicy(policy);
+
+ EXPECT_FALSE(recommended_store->GetValue(prefs::kPromptForDownload, &value));
+ EXPECT_TRUE(
+ recommended_store->GetValue(prefs::kDownloadDefaultDirectory, &value));
+ EXPECT_TRUE(value);
+ EXPECT_TRUE(value->GetAsString(&download_directory));
+ EXPECT_EQ(GetExpectedDownloadDirectory() + kRelativeToDriveRoot,
+ download_directory);
+}
+#endif

Powered by Google App Engine
This is Rietveld 408576698