Set drive as the default download folder

components/policy/core/browser/configuration_policy_handler.h

Index: components/policy/core/browser/configuration_policy_handler.h
diff --git a/components/policy/core/browser/configuration_policy_handler.h b/components/policy/core/browser/configuration_policy_handler.h
index b564d0e3cb270b59b8398ba7547ab82074937601..5a20746d3177ed4346679dde15d28822b8c28b6c 100644
--- a/components/policy/core/browser/configuration_policy_handler.h
+++ b/components/policy/core/browser/configuration_policy_handler.h
@@ -22,6 +22,7 @@ namespace policy {
 
 class PolicyErrorMap;
 class PolicyMap;
+struct PolicyHandlerParameters;

[bartfab (slow), 2014/03/14 13:43:45]

Nit: Arrange in alphabetic order.

 
 // Maps a policy type to a preference path, and to the expected value type.
 struct POLICY_EXPORT PolicyToPreferenceMapEntry {
@@ -49,7 +50,16 @@ class POLICY_EXPORT ConfigurationPolicyHandler {
   // Processes the policies handled by this ConfigurationPolicyHandler and sets
   // the appropriate preferences in |prefs|.
   virtual void ApplyPolicySettings(const PolicyMap& policies,
-                                   PrefValueMap* prefs) = 0;
+                                   PrefValueMap* prefs);
+
+  // Processes the policies handled by this ConfigurationPolicyHandler and sets
+  // the appropriate preferences in |prefs|.
+  // This function takes an additional input that is used to supply

[bartfab (slow), 2014/03/14 13:43:45]

Nit: You can simplify this sentence, especially "supply parameters in
|parameters|" is unnecessarily verbose. How about:

This method forwards additional |parameters| to the policy handler.

+  // parameters in |parameters| to the policy handler.
+  virtual void ApplyPolicySettingsWithParameters(

[bartfab (slow), 2014/03/14 13:43:45]

Since PolicyHandlerList always invokes ApplyPolicySettingsWithParameters(), this
is now the default entry point. You should document this. Instead of saying that
ApplyPolicySettingsWithParameters() takes additional |parameters|, it would be
better to document ApplyPolicySettings() as a convenience version of
ApplyPolicySettingsWithParameters() that leaves out the parameters, to be used
by those not interested in |parameters|. I would then swap the order of the two
methods so that the default entry point ApplyPolicySettingsWithParameters()
appears first.

+      const PolicyMap& policies,
+      const PolicyHandlerParameters& parameters,
+      PrefValueMap* prefs);
 
   // Modifies the values of some of the policies in |policies| so that they
   // are more suitable to display to the user. This can be used to remove