components/policy/core/browser/configuration_policy_handler_parameters.h - Issue 197013007: Set drive as the default download folder

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/policy/core/browser/configuration_policy_handler_parameters.h

Issue 197013007: Set drive as the default download folder (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Version 1 Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
	bartfab (slow) 2014/03/13 13:20:00 Nit 1: s/2012/2014/ Nit 2: There are two variants Nit 1: s/2012/2014/ Nit 2: There are two variants of this header, one with (c) and one without. Last I heard, the version without (c) was preferred for some reason.
	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef COMPONENTS_POLICY_CORE_BROWSER_CONFIGURATION_POLICY_HANDLER_PARAMETERS_H _

	6 #define COMPONENTS_POLICY_CORE_BROWSER_CONFIGURATION_POLICY_HANDLER_PARAMETERS_H _

	7

	8 namespace policy {

	9
	bartfab (slow) 2014/03/13 13:20:00 Nit: Document what this struct is for. Nit: Document what this struct is for.
	10 struct POLICY_EXPORT PolicyHandlerParameters {
	bartfab (slow) 2014/03/13 13:20:00 Nit: #include "components/policy/policy_export.h" Nit: #include "components/policy/policy_export.h"
	11 std::string active_username_hash;
	bartfab (slow) 2014/03/13 13:20:00 1: Remove the "active_" prefix. When the Configura 1: Remove the "active_" prefix. When the ConfigurationPolicyHandlers are running, they are processing policies for a particular user. The fact that this happens to be the currently active user is a Chrome OS implementation detail. 2: Nit: #include <string> 3: Nit: s/username/user_id/
	12 };

	13

	14 } // namespace policy

	15

	16 #endif // COMPONENTS_POLICY_CORE_BROWSER_CONFIGURATION_POLICY_HANDLER_PARAMETER S_H_

OLD	NEW