Set drive as the default download folder

components/policy/core/browser/configuration_policy_handler.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_POLICY_CORE_BROWSER_CONFIGURATION_POLICY_HANDLER_H_
 #define COMPONENTS_POLICY_CORE_BROWSER_CONFIGURATION_POLICY_HANDLER_H_
 
 #include <string>
 #include <vector>
 
 #include "base/basictypes.h"
 #include "base/compiler_specific.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/memory/scoped_vector.h"
 #include "base/values.h"
 #include "components/policy/core/common/schema.h"
 #include "components/policy/policy_export.h"
 
 class PrefValueMap;
 
 namespace policy {
 
 class PolicyErrorMap;
 class PolicyMap;
+struct PolicyHandlerParameters;
 
 // Maps a policy type to a preference path, and to the expected value type.
 struct POLICY_EXPORT PolicyToPreferenceMapEntry {
   const char* const policy_name;
   const char* const preference_path;
   const base::Value::Type value_type;
 };
 
 // An abstract super class that subclasses should implement to map policies to
 // their corresponding preferences, and to check whether the policies are valid.
 class POLICY_EXPORT ConfigurationPolicyHandler {
  public:
   static std::string ValueTypeToString(base::Value::Type type);
 
   ConfigurationPolicyHandler();
   virtual ~ConfigurationPolicyHandler();
 
   // Returns whether the policy settings handled by this
   // ConfigurationPolicyHandler can be applied.  Fills |errors| with error
   // messages or warnings.  |errors| may contain error messages even when
   // |CheckPolicySettings()| returns true.
   virtual bool CheckPolicySettings(const PolicyMap& policies,
                                    PolicyErrorMap* errors) = 0;
 
   // Processes the policies handled by this ConfigurationPolicyHandler and sets
   // the appropriate preferences in |prefs|.
   virtual void ApplyPolicySettings(const PolicyMap& policies,
                                    PrefValueMap* prefs) = 0;
 
+  // Processes the policies handled by this ConfigurationPolicyHandler and sets
+  // the appropriate preferences in |prefs|.
+  // This function takes an additional input that could be used to supply

[bartfab (slow), 2014/03/13 13:20:00]

Nit: "that could be used to supply" makes no sense. The additional input *is*
used to supply additional parameters. You cannot call this method without
supplying parameters.

+  // parameters in |pars| to the policy handlers.

[bartfab (slow), 2014/03/13 13:20:00]

Nit: s/handlers/handler/

+  virtual void ApplyPolicySettingsWithPars(const PolicyMap& policies,

[bartfab (slow), 2014/03/13 13:20:00]

Nit: Avoid abbreviations: s/Pars/Parameters/

+                                           const PolicyHandlerParameters& pars,

[bartfab (slow), 2014/03/13 13:20:00]

Nit: Avoid abbreviations: s/pars/parameters/

+                                           PrefValueMap* prefs);
+
   // Modifies the values of some of the policies in |policies| so that they
   // are more suitable to display to the user. This can be used to remove
   // sensitive values such as passwords, or to pretty-print values.
   virtual void PrepareForDisplaying(PolicyMap* policies) const;
 
  private:
   DISALLOW_COPY_AND_ASSIGN(ConfigurationPolicyHandler);
 };
 
 // Abstract class derived from ConfigurationPolicyHandler that should be
@@ skipping 219 matching lines @@
  private:
   ScopedVector<ConfigurationPolicyHandler> legacy_policy_handlers_;
   scoped_ptr<SchemaValidatingPolicyHandler> new_policy_handler_;
 
   DISALLOW_COPY_AND_ASSIGN(LegacyPoliciesDeprecatingPolicyHandler);
 };
 
 }  // namespace policy
 
 #endif  // COMPONENTS_POLICY_CORE_BROWSER_CONFIGURATION_POLICY_HANDLER_H_