Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(489)

Issue 197013003: Clean up SkImageFilter. (Closed)

Created:
6 years, 9 months ago by Dominik Grewe
Modified:
6 years, 9 months ago
Reviewers:
Stephen White
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Clean up SkImageFilter. Rename more occurences of 'target' to 'kernelOffset'. This is a follow-up patch to https://codereview.chromium.org/182983003/ BUG=skia:2187 Committed: http://code.google.com/p/skia/source/detail?r=13768

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -21 lines) Patch
M bench/MatrixConvolutionBench.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M gm/matrixconvolution.cpp View 3 chunks +14 lines, -14 lines 0 comments Download
M src/effects/SkMatrixConvolutionImageFilter.cpp View 3 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Dominik Grewe
PTAL.
6 years, 9 months ago (2014-03-12 10:06:31 UTC) #1
Stephen White
LGTM
6 years, 9 months ago (2014-03-12 14:02:18 UTC) #2
Dominik Grewe
The CQ bit was checked by dominikg@chromium.org
6 years, 9 months ago (2014-03-12 15:30:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/dominikg@chromium.org/197013003/1
6 years, 9 months ago (2014-03-12 15:30:56 UTC) #4
commit-bot: I haz the power
6 years, 9 months ago (2014-03-12 16:36:11 UTC) #5
Message was sent while issue was closed.
Change committed as 13768

Powered by Google App Engine
This is Rietveld 408576698