Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(458)

Issue 1970123002: [turbofan] Deoptimize on access to neutered typed arrays. (Closed)

Created:
4 years, 7 months ago by Benedikt Meurer
Modified:
4 years, 7 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Deoptimize on access to neutered typed arrays. We got the condition wrong and actually deoptimized when the typed array was not neutered. This fixes the deopt loop in Math.random and actually many programs that use typed arrays. R=jarin@chromium.org Committed: https://crrev.com/8f1e31fe7545e28162e774183bb1603d90ff0d3f Cr-Commit-Position: refs/heads/master@{#36194}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -21 lines) Patch
M src/compiler/js-native-context-specialization.cc View 1 chunk +1 line, -1 line 0 comments Download
A + test/mjsunit/compiler/optimized-float32array-length.js View 1 chunk +7 lines, -5 lines 0 comments Download
A + test/mjsunit/compiler/optimized-float64array-length.js View 1 chunk +7 lines, -5 lines 0 comments Download
A + test/mjsunit/compiler/optimized-int32array-length.js View 1 chunk +7 lines, -5 lines 0 comments Download
A + test/mjsunit/compiler/optimized-uint32array-length.js View 1 chunk +7 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Benedikt Meurer
4 years, 7 months ago (2016-05-12 05:57:53 UTC) #1
Benedikt Meurer
Hey Jaro, Here's the fix for the deopt loop. Please take a look. Thanks, Benedikt
4 years, 7 months ago (2016-05-12 06:23:38 UTC) #2
Jarin
lgtm
4 years, 7 months ago (2016-05-12 06:24:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1970123002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1970123002/1
4 years, 7 months ago (2016-05-12 06:24:49 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-12 06:29:11 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-12 06:30:02 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8f1e31fe7545e28162e774183bb1603d90ff0d3f
Cr-Commit-Position: refs/heads/master@{#36194}

Powered by Google App Engine
This is Rietveld 408576698