third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.cpp - Issue 1970003004: Worker: Move close() from WorkerGlobalScope to derived interfaces

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.cpp

Issue 1970003004: Worker: Move close() from WorkerGlobalScope to derived interfaces (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add const Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.cpp

diff --git a/third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.cpp b/third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.cpp

index 471de234d334dbe63c9126a5f2baeccb75d78617..baca0da644f478fac1950ae992d614c4229e995d 100644

--- a/third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.cpp

+++ b/third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.cpp

@@ -244,8 +244,9 @@ void ServiceWorkerGlobalScopeProxy::workerGlobalScopeStarted(WorkerGlobalScope*

void ServiceWorkerGlobalScopeProxy::workerGlobalScopeClosed()

{

- DCHECK(m_embeddedWorker);

- document().postTask(BLINK_FROM_HERE, createCrossThreadTask(&WebEmbeddedWorkerImpl::terminateWorkerContext, AllowCrossThreadAccess(m_embeddedWorker)));

+ // This should never be called because close() is not defined in

+ // ServiceWorkerGlobalScope.

+ NOTREACHED();

}

void ServiceWorkerGlobalScopeProxy::willDestroyWorkerGlobalScope()

« no previous file with comments | « third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerGlobalScope.idl ('k') | no next file » | no next file with comments »