Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(525)

Issue 19700009: Fixing perfbots for run_measurements (Closed)

Created:
7 years, 5 months ago by edmundyan
Modified:
7 years, 5 months ago
Reviewers:
dtu, tonyg
CC:
chromium-reviews, chrome-speed-team+watch_google.com, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M tools/telemetry/telemetry/core/repeat_options.py View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
edmundyan
This is a fix for run_measurements which explicitly sets pageset_repeat. This will not fix benchmarks, ...
7 years, 5 months ago (2013-07-24 19:01:58 UTC) #1
dtu
lgtm
7 years, 5 months ago (2013-07-24 19:04:59 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/edmundyan@chromium.org/19700009/1
7 years, 5 months ago (2013-07-24 19:20:57 UTC) #3
tonyg
On 2013/07/24 19:20:57, I haz the power (commit-bot) wrote: > CQ is trying da patch. ...
7 years, 5 months ago (2013-07-24 19:22:44 UTC) #4
tonyg
Also, do we need a new unittest that would have caught this breakage?
7 years, 5 months ago (2013-07-24 21:59:42 UTC) #5
dtu
Committed patchset #1 manually as r213527 (presubmit successful).
7 years, 5 months ago (2013-07-24 22:06:04 UTC) #6
dtu
7 years, 5 months ago (2013-07-24 22:07:37 UTC) #7
Message was sent while issue was closed.
On 2013/07/24 22:06:04, Dave Tu wrote:
> Committed patchset #1 manually as r213527 (presubmit successful).

Lol I remembered that I can dcommit other people's patches. Done.
Don't worry about those trybot failures, they don't look relevant.

Powered by Google App Engine
This is Rietveld 408576698