Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 1969993002: Revert of Disable DomDistillerViewerSourceBrowserTest.NoWebUIBindingsArticle{Exists,NotFound} tests. (Closed)

Created:
4 years, 7 months ago by mdjones
Modified:
4 years, 7 months ago
CC:
chromium-reviews
Base URL:
http://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Disable DomDistillerViewerSourceBrowserTest.NoWebUIBindingsArticle{Exists,NotFound} tests. (patchset #2 id:20001 of https://codereview.chromium.org/1911733002/ ) Reason for revert: A change landed that fixes the reason these became flaky (https://codereview.chromium.org/1920563002/). Original issue's description: > Disable DomDistillerViewerSourceBrowserTest.NoWebUIBindingsArticle{Exists,NotFound} tests. > > Starting with https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%281%29/builds/53656 > these tests became flaky: > DomDistillerViewerSourceBrowserTest.NoWebUIBindingsArticleExists > DomDistillerViewerSourceBrowserTest.NoWebUIBindingsArticleNotFound > > BUG=605432 > TBR=nyquist@chromium.org > > Committed: https://crrev.com/620c8a6cf23eebb0497ff4e64216fdaa8818433a > Cr-Commit-Position: refs/heads/master@{#388722} TBR=nyquist@chromium.org,kjellander@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=605432 Committed: https://crrev.com/e9599ecbdf0f63640aea7b07f601b9bf6949b665 Cr-Commit-Position: refs/heads/master@{#393136}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -16 lines) Patch
M chrome/browser/dom_distiller/dom_distiller_viewer_source_browsertest.cc View 2 chunks +4 lines, -16 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
mdjones
Created Revert of Disable DomDistillerViewerSourceBrowserTest.NoWebUIBindingsArticle{Exists,NotFound} tests.
4 years, 7 months ago (2016-05-11 23:44:46 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1969993002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1969993002/1
4 years, 7 months ago (2016-05-11 23:45:24 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-12 01:30:34 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/e9599ecbdf0f63640aea7b07f601b9bf6949b665 Cr-Commit-Position: refs/heads/master@{#393136}
4 years, 7 months ago (2016-05-12 01:32:06 UTC) #5
kjellander_chromium
4 years, 7 months ago (2016-05-12 05:46:40 UTC) #6
Message was sent while issue was closed.
lgtm, nice to see tests being fixed

Powered by Google App Engine
This is Rietveld 408576698