Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(25)

Issue 1969953002: Make TreeNode.visit return dynamic. (Closed)

Created:
4 years, 5 months ago by Siggi Cherem (dart-lang)
Modified:
4 years, 5 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org, terry
Base URL:
git@github.com:dart-lang/csslib.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Make TreeNode.visit return dynamic. Subclasses of TreeNode already do `visit(visitor) => visitor.visitSomething(this)`, this just exposes it at the root of the tree hierarchy. This is needed for package:html, where we have code that would do the equivalent of `x = node.visit(myVisitor)`. R=rnystrom@google.com Committed: https://github.com/dart-lang/csslib/commit/a40f8abfe0c475fbc97cd14069f71496ea76552a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M CHANGELOG.md View 1 chunk +4 lines, -0 lines 0 comments Download
M lib/src/tree_base.dart View 1 chunk +1 line, -1 line 0 comments Download
M pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
Siggi Cherem (dart-lang)
4 years, 5 months ago (2016-05-11 22:16:35 UTC) #2
Bob Nystrom
lgtm
4 years, 5 months ago (2016-05-11 23:07:25 UTC) #3
Siggi Cherem (dart-lang)
4 years, 5 months ago (2016-05-11 23:07:59 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
a40f8abfe0c475fbc97cd14069f71496ea76552a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698