Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(367)

Issue 1969943002: Resynthesize _DeferredClassElement lazily. (Closed)

Created:
4 years, 7 months ago by scheglov
Modified:
4 years, 7 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Resynthesize _DeferredClassElement lazily. This reduces DDC analysis time for the test codebase from 617 ms. to 447 ms, i.e. about 35% down. R=brianwilkerson@google.com, paulberry@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/b68f3b24a61a3b83f52c265b8cf49639a1ffd5b1

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+181 lines, -51 lines) Patch
M pkg/analyzer/lib/src/dart/element/element.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analyzer/lib/src/dart/element/handle.dart View 4 chunks +82 lines, -26 lines 1 comment Download
M pkg/analyzer/lib/src/summary/resynthesize.dart View 8 chunks +96 lines, -23 lines 1 comment Download
M pkg/analyzer/test/src/summary/resynthesize_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
scheglov
4 years, 7 months ago (2016-05-11 21:58:23 UTC) #1
Brian Wilkerson
lgtm
4 years, 7 months ago (2016-05-11 22:05:20 UTC) #2
Paul Berry
lgtm https://codereview.chromium.org/1969943002/diff/1/pkg/analyzer/lib/src/dart/element/handle.dart File pkg/analyzer/lib/src/dart/element/handle.dart (right): https://codereview.chromium.org/1969943002/diff/1/pkg/analyzer/lib/src/dart/element/handle.dart#newcode472 pkg/analyzer/lib/src/dart/element/handle.dart:472: print('No actualElement: $location $runtimeType'); Looks like temporary debugging ...
4 years, 7 months ago (2016-05-11 22:09:37 UTC) #3
scheglov
4 years, 7 months ago (2016-05-12 00:24:44 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b68f3b24a61a3b83f52c265b8cf49639a1ffd5b1 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698