Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1969933002:
[Offline pages] Marking obsolete user actions as such (Closed)
Description[Offline pages] Marking obsolete user actions as such
This leaves only the snackbar reload action as still valid in the actions.xml
BUG=610877
R=dewittj@chromium.org
Committed: https://crrev.com/707acf00b575c669c3ccb4baabdfa7ea6d766790
Cr-Commit-Position: refs/heads/master@{#393279}
Patch Set 1 #
Messages
Total messages: 18 (8 generated)
PTAL
lgtm
The CQ bit was checked by fgorski@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1969933002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1969933002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
fgorski@chromium.org changed reviewers: + isherman@chromium.org
+isherman@ for owners review, please.
Description was changed from ========== [Offline pages] Marking obsolete user actions as such This leaves only the snackbar reload action as still valid in the actions.xml BUG=610877 R=dewittj@chromium.org ========== to ========== [Offline pages] Marking obsolete user actions as such This leaves only the snackbar reload action as still valid in the actions.xml BUG=610877 R=dewittj@chromium.org ==========
fgorski@chromium.org changed reviewers: + asvitkine@chromium.org - isherman@chromium.org
On 2016/05/12 16:37:42, fgorski wrote: > mailto:fgorski@chromium.org changed reviewers: > + mailto:asvitkine@chromium.org > - mailto:isherman@chromium.org asvitkine@, please do the OWNERS review. thanks.
lgtm
The CQ bit was checked by fgorski@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1969933002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1969933002/1
Message was sent while issue was closed.
Description was changed from ========== [Offline pages] Marking obsolete user actions as such This leaves only the snackbar reload action as still valid in the actions.xml BUG=610877 R=dewittj@chromium.org ========== to ========== [Offline pages] Marking obsolete user actions as such This leaves only the snackbar reload action as still valid in the actions.xml BUG=610877 R=dewittj@chromium.org ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== [Offline pages] Marking obsolete user actions as such This leaves only the snackbar reload action as still valid in the actions.xml BUG=610877 R=dewittj@chromium.org ========== to ========== [Offline pages] Marking obsolete user actions as such This leaves only the snackbar reload action as still valid in the actions.xml BUG=610877 R=dewittj@chromium.org Committed: https://crrev.com/707acf00b575c669c3ccb4baabdfa7ea6d766790 Cr-Commit-Position: refs/heads/master@{#393279} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/707acf00b575c669c3ccb4baabdfa7ea6d766790 Cr-Commit-Position: refs/heads/master@{#393279} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
