Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1617)

Unified Diff: pkg/analysis_server/test/domain_server_test.dart

Issue 196993003: add sdkPath and enable tests (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: merge Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analysis_server/test/domain_context_test.dart ('k') | pkg/analysis_server/test/mocks.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analysis_server/test/domain_server_test.dart
diff --git a/pkg/analysis_server/test/domain_server_test.dart b/pkg/analysis_server/test/domain_server_test.dart
index 3f39068398f95fdd8bf2e2cbc779fcfe45db226b..b1e3d23808789d8ad5b0b48d4b61a2b879c7d767 100644
--- a/pkg/analysis_server/test/domain_server_test.dart
+++ b/pkg/analysis_server/test/domain_server_test.dart
@@ -13,14 +13,14 @@ import 'package:unittest/unittest.dart';
import 'mocks.dart';
main() {
-// group('ServerDomainHandler', () {
-//// test('createContext', ServerDomainHandlerTest.createContext);
-//// test('deleteContext_alreadyDeleted', ServerDomainHandlerTest.deleteContext_alreadyDeleted);
-// test('deleteContext_doesNotExist', ServerDomainHandlerTest.deleteContext_doesNotExist);
-//// test('deleteContext_existing', ServerDomainHandlerTest.deleteContext_existing);
-// test('shutdown', ServerDomainHandlerTest.shutdown);
-// test('version', ServerDomainHandlerTest.version);
-// });
+ group('ServerDomainHandler', () {
+// test('createContext', ServerDomainHandlerTest.createContext);
+// test('deleteContext_alreadyDeleted', ServerDomainHandlerTest.deleteContext_alreadyDeleted);
+ test('deleteContext_doesNotExist', ServerDomainHandlerTest.deleteContext_doesNotExist);
+// test('deleteContext_existing', ServerDomainHandlerTest.deleteContext_existing);
+ test('shutdown', ServerDomainHandlerTest.shutdown);
+ test('version', ServerDomainHandlerTest.version);
+ });
}
class ServerDomainHandlerTest {
@@ -29,7 +29,7 @@ class ServerDomainHandlerTest {
ServerDomainHandler handler = new ServerDomainHandler(server);
Request createRequest = new Request('0', ServerDomainHandler.CREATE_CONTEXT_METHOD);
- createRequest.setParameter(ServerDomainHandler.SDK_DIRECTORY_PARAM, '');
+ createRequest.setParameter(ServerDomainHandler.SDK_DIRECTORY_PARAM, sdkPath);
Response response = handler.handleRequest(createRequest);
String contextId = response.getResult(ServerDomainHandler.CONTEXT_ID_RESULT);
expect(contextId, isNotNull);
@@ -61,10 +61,8 @@ class ServerDomainHandlerTest {
Request deleteRequest = new Request('0', ServerDomainHandler.DELETE_CONTEXT_METHOD);
deleteRequest.setParameter(ServerDomainHandler.CONTEXT_ID_PARAM, 'xyzzy');
Response response = handler.handleRequest(deleteRequest);
- expect(response.toJson(), equals({
- Response.ID: '0',
- Response.ERROR: 'Context does not exist'
- }));
+ expect(response.id, equals('0'));
+ expect(response.error, isNotNull);
}
static void deleteContext_existing() {
« no previous file with comments | « pkg/analysis_server/test/domain_context_test.dart ('k') | pkg/analysis_server/test/mocks.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698