Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Unified Diff: pkg/analysis_server/test/domain_context_test.dart

Issue 196993003: add sdkPath and enable tests (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: merge Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/test/domain_context_test.dart
diff --git a/pkg/analysis_server/test/domain_context_test.dart b/pkg/analysis_server/test/domain_context_test.dart
index 42b801089da450b84990f5fb37705bddf037db6e..850a94e2d06cdaeaf42b20ba4c2369c9031763ff 100644
--- a/pkg/analysis_server/test/domain_context_test.dart
+++ b/pkg/analysis_server/test/domain_context_test.dart
@@ -15,12 +15,12 @@ import 'package:unittest/unittest.dart';
import 'mocks.dart';
main() {
-// group('ContextDomainHandlerTest', () {
-// test('applyChanges', ContextDomainHandlerTest.applyChanges);
-// test('setOptions', ContextDomainHandlerTest.setOptions);
-// test('setPrioritySources_empty', ContextDomainHandlerTest.setPrioritySources_empty);
-// test('setPrioritySources_nonEmpty', ContextDomainHandlerTest.setPrioritySources_nonEmpty);
-// });
+ group('ContextDomainHandlerTest', () {
+ test('applyChanges', ContextDomainHandlerTest.applyChanges);
+ test('setOptions', ContextDomainHandlerTest.setOptions);
+ test('setPrioritySources_empty', ContextDomainHandlerTest.setPrioritySources_empty);
+ test('setPrioritySources_nonEmpty', ContextDomainHandlerTest.setPrioritySources_nonEmpty);
+ });
}
class ContextDomainHandlerTest {
@@ -32,7 +32,9 @@ class ContextDomainHandlerTest {
Request request = new Request('0', ContextDomainHandler.APPLY_CHANGES_NAME);
request.setParameter(ContextDomainHandler.CONTEXT_ID_PARAM, contextId);
- request.setParameter(ContextDomainHandler.CHANGES_PARAM, changeSet);
+ // TODO (danrubel) convert ChangeSet to Map
+// request.setParameter(ContextDomainHandler.CHANGES_PARAM, changeSet);
+ request.setParameter(ContextDomainHandler.CHANGES_PARAM, new Map());
Response response = handler.handleRequest(request);
expect(response.toJson(), equals({
Response.ID: '0',
@@ -92,8 +94,9 @@ class ContextDomainHandlerTest {
static String _createContext(AnalysisServer server) {
ServerDomainHandler handler = new ServerDomainHandler(server);
Request request = new Request('0', ServerDomainHandler.CREATE_CONTEXT_METHOD);
- request.setParameter(ServerDomainHandler.SDK_DIRECTORY_PARAM, '');
+ request.setParameter(ServerDomainHandler.SDK_DIRECTORY_PARAM, sdkPath);
Response response = handler.handleRequest(request);
+ expect(response.error, isNull);
return response.getResult(ServerDomainHandler.CONTEXT_ID_RESULT);
}
}
« no previous file with comments | « pkg/analysis_server/test/analysis_server_test.dart ('k') | pkg/analysis_server/test/domain_server_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698