Source/modules/webaudio/PannerNode.h - Issue 196993002: Guarantee a thread safety when accessing source location info in pannerNode.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/webaudio/PannerNode.h

Issue 196993002: Guarantee a thread safety when accessing source location info in pannerNode. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/modules/webaudio/PannerNode.h

diff --git a/Source/modules/webaudio/PannerNode.h b/Source/modules/webaudio/PannerNode.h

index 3f5ef90618a2ba36a15dfe43c0675e7e40552d7f..edbc9bee2142db08449e2ecfcc11850609a32153 100644

--- a/Source/modules/webaudio/PannerNode.h

+++ b/Source/modules/webaudio/PannerNode.h

@@ -176,8 +176,8 @@ private:

// AudioContext's connection count

unsigned m_connectionCount;

- // Synchronize process() and setPanningModel() which can change the panner.

- mutable Mutex m_pannerLock;

+ // Synchronize process() with setting of the panning model, distance model and caching of the source location/orientation info.

+ mutable Mutex m_processLock;

};

} // namespace WebCore

« no previous file with comments | « no previous file | Source/modules/webaudio/PannerNode.cpp » ('j') | Source/modules/webaudio/PannerNode.cpp » ('J')