Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1639)

Unified Diff: Source/modules/webaudio/PannerNode.h

Issue 196993002: Guarantee a thread safety when accessing source location info in pannerNode. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/modules/webaudio/PannerNode.cpp » ('j') | Source/modules/webaudio/PannerNode.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/modules/webaudio/PannerNode.h
diff --git a/Source/modules/webaudio/PannerNode.h b/Source/modules/webaudio/PannerNode.h
index 3f5ef90618a2ba36a15dfe43c0675e7e40552d7f..76c10aa1a4d4e0bfdcb623d03559aa7a477d79cb 100644
--- a/Source/modules/webaudio/PannerNode.h
+++ b/Source/modules/webaudio/PannerNode.h
@@ -176,8 +176,8 @@ private:
// AudioContext's connection count
unsigned m_connectionCount;
- // Synchronize process() and setPanningModel() which can change the panner.
- mutable Mutex m_pannerLock;
+ // Synchronize process() and setters panningModel, distanceModel and source location info.
Raymond Toy 2014/03/13 21:37:46 Update comment: // Synchronize process() with set
KhNo 2014/03/14 10:39:58 Done.
Raymond Toy 2014/03/14 22:30:36 Please use this comment. Your replacement is not q
KhNo 2014/03/15 04:58:16 Done.
+ mutable Mutex m_processLock;
Raymond Toy 2014/03/13 21:37:46 Why change the name?
KhNo 2014/03/14 10:39:58 Previous code only has locked for m_panner which i
Raymond Toy 2014/03/14 22:30:36 Ok.
};
} // namespace WebCore
« no previous file with comments | « no previous file | Source/modules/webaudio/PannerNode.cpp » ('j') | Source/modules/webaudio/PannerNode.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698