content/public/browser/navigation_controller.h - Issue 19699007: Ensure we don't crash if user navigates back from NTP to Chrome sign-in page before it has fully lo…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/browser/navigation_controller.h

Issue 19699007: Ensure we don't crash if user navigates back from NTP to Chrome sign-in page before it has fully lo… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Add test coverage for removing a pending entry. Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/public/browser/navigation_controller.h

diff --git a/content/public/browser/navigation_controller.h b/content/public/browser/navigation_controller.h

index 3b93ef145a864001b4d5bf61b93f56e99b330f98..0aebb005de40ee4047bd289a8adebaafbadbda59 100644

--- a/content/public/browser/navigation_controller.h

+++ b/content/public/browser/navigation_controller.h

@@ -330,10 +330,10 @@ class NavigationController {

// Removing of entries -------------------------------------------------------

- // Removes the entry at the specified |index|. This call dicards any pending

- // and transient entries. If the index is the last committed index, this does

- // nothing and returns false.

- virtual void RemoveEntryAtIndex(int index) = 0;

+ // Removes the entry at the specified |index|. This call dicards any

Charlie Reis 2013/07/19 23:28:43 nit: Might as well fix "discards". Funny that the

nasko 2013/07/22 16:18:28 Done.

+ // transient entries. If the index is the last committed index or the pending

+ // entry, this does nothing and returns false.

+ virtual bool RemoveEntryAtIndex(int index) = 0;

// Random --------------------------------------------------------------------

« chrome/browser/signin/signin_browsertest.cc ('K') | « content/browser/web_contents/navigation_controller_impl_unittest.cc ('k') | no next file » | no next file with comments »