Ensure we don't crash if user navigates back from NTP to Chrome sign-in page before it has fully lo…

content/public/browser/navigation_controller.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_PUBLIC_BROWSER_NAVIGATION_CONTROLLER_H_
 #define CONTENT_PUBLIC_BROWSER_NAVIGATION_CONTROLLER_H_
 
 #include <map>
 #include <string>
 #include <vector>
@@ skipping 317 matching lines @@
   // Like Reload(), but don't use caches (aka "shift-reload").
   virtual void ReloadIgnoringCache(bool check_for_repost) = 0;
 
   // Reloads the current entry using the original URL used to create it.  This
   // is used for cases where the user wants to refresh a page using a different
   // user agent after following a redirect.
   virtual void ReloadOriginalRequestURL(bool check_for_repost) = 0;
 
   // Removing of entries -------------------------------------------------------
 
-  // Removes the entry at the specified |index|.  This call dicards any pending
-  // and transient entries.  If the index is the last committed index, this does
-  // nothing and returns false.
-  virtual void RemoveEntryAtIndex(int index) = 0;
+  // Removes the entry at the specified |index|.  This call discards any
+  // transient entries.  If the index is the last committed index or the pending
+  // entry, this does nothing and returns false.
+  virtual bool RemoveEntryAtIndex(int index) = 0;
 
   // Random --------------------------------------------------------------------
 
   // Session storage depends on dom_storage that depends on WebKit::WebString,
   // which cannot be used on iOS.
 #if !defined(OS_IOS)
   // Returns all the SessionStorageNamespace objects that this
   // NavigationController knows about.
   virtual const SessionStorageNamespaceMap&
       GetSessionStorageNamespaceMap() const = 0;
@@ skipping 74 matching lines @@
 
  private:
   // This interface should only be implemented inside content.
   friend class NavigationControllerImpl;
   NavigationController() {}
 };
 
 }  // namespace content
 
 #endif  // CONTENT_PUBLIC_BROWSER_NAVIGATION_CONTROLLER_H_