Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(878)

Side by Side Diff: content/public/browser/navigation_controller.h

Issue 19699007: Ensure we don't crash if user navigates back from NTP to Chrome sign-in page before it has fully lo… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fixing nits. Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_PUBLIC_BROWSER_NAVIGATION_CONTROLLER_H_ 5 #ifndef CONTENT_PUBLIC_BROWSER_NAVIGATION_CONTROLLER_H_
6 #define CONTENT_PUBLIC_BROWSER_NAVIGATION_CONTROLLER_H_ 6 #define CONTENT_PUBLIC_BROWSER_NAVIGATION_CONTROLLER_H_
7 7
8 #include <map> 8 #include <map>
9 #include <string> 9 #include <string>
10 #include <vector> 10 #include <vector>
(...skipping 312 matching lines...) Expand 10 before | Expand all | Expand 10 after
323 // Like Reload(), but don't use caches (aka "shift-reload"). 323 // Like Reload(), but don't use caches (aka "shift-reload").
324 virtual void ReloadIgnoringCache(bool check_for_repost) = 0; 324 virtual void ReloadIgnoringCache(bool check_for_repost) = 0;
325 325
326 // Reloads the current entry using the original URL used to create it. This 326 // Reloads the current entry using the original URL used to create it. This
327 // is used for cases where the user wants to refresh a page using a different 327 // is used for cases where the user wants to refresh a page using a different
328 // user agent after following a redirect. 328 // user agent after following a redirect.
329 virtual void ReloadOriginalRequestURL(bool check_for_repost) = 0; 329 virtual void ReloadOriginalRequestURL(bool check_for_repost) = 0;
330 330
331 // Removing of entries ------------------------------------------------------- 331 // Removing of entries -------------------------------------------------------
332 332
333 // Removes the entry at the specified |index|. This call dicards any pending 333 // Removes the entry at the specified |index|. This call discards any
334 // and transient entries. If the index is the last committed index, this does 334 // transient entries. If the index is the last committed index or the pending
335 // nothing and returns false. 335 // entry, this does nothing and returns false.
336 virtual void RemoveEntryAtIndex(int index) = 0; 336 virtual bool RemoveEntryAtIndex(int index) = 0;
337 337
338 // Random -------------------------------------------------------------------- 338 // Random --------------------------------------------------------------------
339 339
340 // Session storage depends on dom_storage that depends on WebKit::WebString, 340 // Session storage depends on dom_storage that depends on WebKit::WebString,
341 // which cannot be used on iOS. 341 // which cannot be used on iOS.
342 #if !defined(OS_IOS) 342 #if !defined(OS_IOS)
343 virtual SessionStorageNamespace* GetSessionStorageNamespace() = 0; 343 virtual SessionStorageNamespace* GetSessionStorageNamespace() = 0;
344 #endif 344 #endif
345 345
346 // Sets the max restored page ID this NavigationController has seen, if it 346 // Sets the max restored page ID this NavigationController has seen, if it
(...skipping 67 matching lines...) Expand 10 before | Expand all | Expand 10 after
414 414
415 private: 415 private:
416 // This interface should only be implemented inside content. 416 // This interface should only be implemented inside content.
417 friend class NavigationControllerImpl; 417 friend class NavigationControllerImpl;
418 NavigationController() {} 418 NavigationController() {}
419 }; 419 };
420 420
421 } // namespace content 421 } // namespace content
422 422
423 #endif // CONTENT_PUBLIC_BROWSER_NAVIGATION_CONTROLLER_H_ 423 #endif // CONTENT_PUBLIC_BROWSER_NAVIGATION_CONTROLLER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698