net/quic/quic_chromium_client_stream.h - Issue 1969893002: Remove unnecessary array allocation in cronet_bidirectional_stream_adapter.cc

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/quic/quic_chromium_client_stream.h

Issue 1969893002: Remove unnecessary array allocation in cronet_bidirectional_stream_adapter.cc (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: self review Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/cronet/android/cronet_bidirectional_stream_adapter.cc ('K') | « net/quic/bidirectional_stream_quic_impl_unittest.cc ('k') | net/quic/quic_chromium_client_stream.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: net/quic/quic_chromium_client_stream.h

diff --git a/net/quic/quic_chromium_client_stream.h b/net/quic/quic_chromium_client_stream.h

index 78884f611d563e1e546d6fafe31de914b9c7a4af..1a66865182f4e49f7630e28d9f7a263e02db8bba 100644

--- a/net/quic/quic_chromium_client_stream.h

+++ b/net/quic/quic_chromium_client_stream.h

@@ -82,7 +82,7 @@ class NET_EXPORT_PRIVATE QuicChromiumClientStream : public QuicSpdyStream {

const CompletionCallback& callback);

// Same as WriteStreamData except it writes data from a vector of IOBuffers,

// with the length of each buffer at the corresponding index in |lengths|.

- int WritevStreamData(const std::vector<IOBuffer*>& buffers,

+ int WritevStreamData(const std::vector<scoped_refptr<IOBuffer>>& buffers,

const std::vector<int>& lengths,

bool fin,

const CompletionCallback& callback);