Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(676)

Unified Diff: net/spdy/bidirectional_stream_spdy_impl.h

Issue 1969893002: Remove unnecessary array allocation in cronet_bidirectional_stream_adapter.cc (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add include vector Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/quic_chromium_client_stream_test.cc ('k') | net/spdy/bidirectional_stream_spdy_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/spdy/bidirectional_stream_spdy_impl.h
diff --git a/net/spdy/bidirectional_stream_spdy_impl.h b/net/spdy/bidirectional_stream_spdy_impl.h
index 951c6aeeb46c6de967a915a21feccbe09a50a7b5..2ddd4f8fb1029846b3a12d86d17e87e2a1354403 100644
--- a/net/spdy/bidirectional_stream_spdy_impl.h
+++ b/net/spdy/bidirectional_stream_spdy_impl.h
@@ -8,8 +8,10 @@
#include <stdint.h>
#include <memory>
+#include <vector>
#include "base/macros.h"
+#include "base/memory/ref_counted.h"
#include "base/memory/weak_ptr.h"
#include "net/http/bidirectional_stream_impl.h"
#include "net/http/bidirectional_stream_request_info.h"
@@ -44,8 +46,10 @@ class NET_EXPORT_PRIVATE BidirectionalStreamSpdyImpl
BidirectionalStreamImpl::Delegate* delegate,
std::unique_ptr<base::Timer> timer) override;
int ReadData(IOBuffer* buf, int buf_len) override;
- void SendData(IOBuffer* data, int length, bool end_stream) override;
- void SendvData(const std::vector<IOBuffer*>& buffers,
+ void SendData(const scoped_refptr<IOBuffer>& data,
+ int length,
+ bool end_stream) override;
+ void SendvData(const std::vector<scoped_refptr<IOBuffer>>& buffers,
const std::vector<int>& lengths,
bool end_stream) override;
void Cancel() override;
« no previous file with comments | « net/quic/quic_chromium_client_stream_test.cc ('k') | net/spdy/bidirectional_stream_spdy_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698