Issue 1969843002: VM: Another fix for precompiling with >1 iterations.

Issue 1969843002: VM: Another fix for precompiling with >1 iterations. (Closed)

Created:
4 years, 7 months ago by Florian Schneider

Modified:
4 years, 7 months ago

Reviewers:
rmacnak

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

VM: Another fix for precompiling with >1 iterations. Corrected VM entry points. Fixed collection of unique function names. Removed wrong assertion. Clean up unused code. BUG= R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/39a1a304150927c40340b7ea8c56e3dd14c41e5d

Created: 4 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+18 lines, -35 lines)			Patch
M	runtime/vm/aot_optimizer.cc	View	2 chunks	+7 lines, -2 lines	0 comments	Download
M	runtime/vm/flag_list.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/flow_graph_compiler.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	runtime/vm/object_store.cc	View	2 chunks	+5 lines, -0 lines	0 comments	Download
M	runtime/vm/precompiler.h	View	1 chunk	+0 lines, -10 lines	0 comments	Download
M	runtime/vm/precompiler.cc	View	6 chunks	+5 lines, -21 lines	0 comments	Download

Total messages: 5 (2 generated)

Florian Schneider

With this change, all tests pass with --precompiler-rounds=2.

4 years, 7 months ago (2016-05-11 18:05:22 UTC) #2

Florian Schneider

4 years, 7 months ago (2016-05-12 07:32:38 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
39a1a304150927c40340b7ea8c56e3dd14c41e5d (presubmit successful).