Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 196983011: Clean up some isolate macros. (Closed)

Created:
6 years, 9 months ago by Yang
Modified:
6 years, 9 months ago
Reviewers:
Igor Sheludko
CC:
v8-dev
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -41 lines) Patch
M src/isolate.h View 8 chunks +21 lines, -29 lines 0 comments Download
M src/isolate.cc View 3 chunks +0 lines, -12 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Yang
6 years, 9 months ago (2014-03-14 09:34:03 UTC) #1
Igor Sheludko
lgtm, but note that you are removing TODO comment about max_available_threads_.
6 years, 9 months ago (2014-03-14 12:21:31 UTC) #2
Yang
On 2014/03/14 12:21:31, Igor Sheludko wrote: > lgtm, but note that you are removing TODO ...
6 years, 9 months ago (2014-03-14 12:23:52 UTC) #3
Yang
6 years, 9 months ago (2014-03-14 15:06:23 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r19937 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698