Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(949)

Issue 1969813002: [memory-infra] Improve naming consistency of values reported by memory_metric.html (Closed)

Created:
4 years, 7 months ago by petrcermak
Modified:
4 years, 7 months ago
CC:
catapult-reviews_chromium.org, tracing-review_chromium.org
Base URL:
git@github.com:catapult-project/catapult.git@master
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

[memory-infra] Improve naming consistency of values reported by memory_metric.html This patch: 1. Renames some existing values reported by the memory metric as described in https://goo.gl/Aatx5Z: EXPLICIT SOURCE ATTRIBUTES *:subsystem:{v8, malloc, ...} | v *:subsystem:{v8, malloc, ...}:effective_size ^^^^^^^^^^^^^^ *:subsystem:{v8, malloc, ...}:allocated_objects | v *:subsystem:{v8, malloc, ...}:allocated_objects_size ^^^^^ GROUP EVERYTHING UNDER "SUBSYSTEM" *:android_memtrack:{gl, gfx} | v *:subsystem:gpu:android_memtrack:{gl, gfx, ...}:memtrack_pss ^^^^^^^^^^^^^ ^^^^^^^^^^^^ 2. Augments the memory metric to report the locked (pinned) size of ashmem: *:subsystem:discardable:locked_size ^^^^^^^^^^^ where * stands for memory:{chrome, webview, ...}: {browser, renderer, ..., all}. BUG=chromium:608796 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/767a2ce27e51f8357eae74dabe55caed2f76749d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+172 lines, -86 lines) Patch
M tracing/tracing/metrics/system_health/memory_metric.html View 6 chunks +48 lines, -31 lines 0 comments Download
M tracing/tracing/metrics/system_health/memory_metric_test.html View 13 chunks +99 lines, -55 lines 0 comments Download
M tracing/tracing/model/memory_allocator_dump.html View 1 chunk +5 lines, -0 lines 0 comments Download
M tracing/tracing/model/memory_allocator_dump_test.html View 1 chunk +20 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
petrcermak
PTAL. Thanks, Petr
4 years, 7 months ago (2016-05-11 13:58:11 UTC) #3
Primiano Tucci (use gerrit)
lgtm
4 years, 7 months ago (2016-05-11 18:12:25 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1969813002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1969813002/1
4 years, 7 months ago (2016-05-11 18:47:50 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-11 19:09:08 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

Powered by Google App Engine
This is Rietveld 408576698