Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1969793002: Remove v8_toolset_for_d8 flag (Closed)

Created:
4 years, 7 months ago by jochen (gone - plz use gerrit)
Modified:
4 years, 7 months ago
Reviewers:
Michael Achenbach
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove v8_toolset_for_d8 flag R=machenbach@chromium.org BUG=chromium:609107 Committed: https://crrev.com/6cb38427984f3c31ff6c8813535cfd6ebf6058c4 Cr-Commit-Position: refs/heads/master@{#36198}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -46 lines) Patch
M BUILD.gn View 2 chunks +33 lines, -38 lines 0 comments Download
M gypfiles/toolchain.gypi View 1 chunk +0 lines, -5 lines 0 comments Download
M src/d8.gyp View 3 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
jochen (gone - plz use gerrit)
4 years, 7 months ago (2016-05-11 13:03:56 UTC) #1
Michael Achenbach
lgtm
4 years, 7 months ago (2016-05-11 13:26:12 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1969793002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1969793002/1
4 years, 7 months ago (2016-05-12 07:47:51 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-12 07:49:34 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/6cb38427984f3c31ff6c8813535cfd6ebf6058c4 Cr-Commit-Position: refs/heads/master@{#36198}
4 years, 7 months ago (2016-05-12 07:49:51 UTC) #7
Michael Hablich
4 years, 7 months ago (2016-05-12 13:21:00 UTC) #8
Message was sent while issue was closed. 
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1974773002/ by hablich@chromium.org.

The reason for reverting is: blocks roll:
https://codereview.chromium.org/1975753002/.

Powered by Google App Engine
This is Rietveld 408576698