Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 1969783002: Collect call counts for constructor calls, too. (Closed)

Created:
4 years, 7 months ago by mvstanton
Modified:
4 years, 7 months ago
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-x87-ports_googlegroups.com, rmcilroy, v8-ppc-ports_googlegroups.com, oth
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Collect call counts for constructor calls, too. The TurboFan inliner makes use of these counts. BUG= Committed: https://crrev.com/a6ddbef0645a944fc3d46d89af6362d585170348 Cr-Commit-Position: refs/heads/master@{#36472}

Patch Set 1 #

Patch Set 2 : Also ARM. #

Patch Set 3 : Ports. #

Patch Set 4 : Added a test. #

Patch Set 5 : Updated status file. #

Total comments: 2

Patch Set 6 : Fixed cctest.status, and addressed mips64 comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+170 lines, -26 lines) Patch
M src/arm/code-stubs-arm.cc View 1 2 3 4 5 4 chunks +21 lines, -3 lines 0 comments Download
M src/arm64/code-stubs-arm64.cc View 1 2 3 4 5 4 chunks +24 lines, -3 lines 0 comments Download
M src/ast/ast.h View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 1 2 3 4 5 4 chunks +18 lines, -3 lines 0 comments Download
M src/mips/code-stubs-mips.cc View 1 2 3 4 5 4 chunks +20 lines, -3 lines 0 comments Download
M src/mips64/code-stubs-mips64.cc View 1 2 3 4 5 4 chunks +23 lines, -3 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 1 2 3 4 5 4 chunks +20 lines, -8 lines 0 comments Download
M test/cctest/cctest.status View 1 2 3 4 5 2 chunks +2 lines, -0 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/CallNew.golden View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M test/cctest/test-feedback-vector.cc View 1 2 3 1 chunk +36 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
mvstanton
Hi Benedikt, Here is the basic capability. See if that helps you out, and I'll ...
4 years, 7 months ago (2016-05-12 13:48:41 UTC) #2
Benedikt Meurer
Yep, very nice. That should do the trick initially.
4 years, 7 months ago (2016-05-12 17:56:19 UTC) #3
mvstanton
Hi Benedikt, Here are the ports and a test. thx! --Mike
4 years, 7 months ago (2016-05-20 14:43:45 UTC) #4
Benedikt Meurer
LGTM modulo test failures.
4 years, 7 months ago (2016-05-24 04:48:14 UTC) #5
balazs.kilvady
lgtm on MIPS with a nit: https://codereview.chromium.org/1969783002/diff/80001/src/mips64/code-stubs-mips64.cc File src/mips64/code-stubs-mips64.cc (right): https://codereview.chromium.org/1969783002/diff/80001/src/mips64/code-stubs-mips64.cc#newcode2005 src/mips64/code-stubs-mips64.cc:2005: On MIPS64 we ...
4 years, 7 months ago (2016-05-24 10:16:03 UTC) #7
mvstanton
Thx, submitting. https://codereview.chromium.org/1969783002/diff/80001/src/mips64/code-stubs-mips64.cc File src/mips64/code-stubs-mips64.cc (right): https://codereview.chromium.org/1969783002/diff/80001/src/mips64/code-stubs-mips64.cc#newcode2005 src/mips64/code-stubs-mips64.cc:2005: On 2016/05/24 10:16:02, balazs.kilvady wrote: > On ...
4 years, 7 months ago (2016-05-24 11:20:22 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1969783002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1969783002/100001
4 years, 7 months ago (2016-05-24 11:20:40 UTC) #11
commit-bot: I haz the power
Committed patchset #6 (id:100001)
4 years, 7 months ago (2016-05-24 11:53:19 UTC) #12
commit-bot: I haz the power
4 years, 7 months ago (2016-05-24 11:53:54 UTC) #14
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/a6ddbef0645a944fc3d46d89af6362d585170348
Cr-Commit-Position: refs/heads/master@{#36472}

Powered by Google App Engine
This is Rietveld 408576698