Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issue 1969773002: [Interpreter] Clean up runtime-profiler logic for three tier pipeline. (Closed)

Created:
4 years, 7 months ago by rmcilroy
Modified:
4 years, 7 months ago
Reviewers:
Michael Starzinger
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Interpreter] Clean up runtime-profiler logic for three tier pipeline. Remove checks for IC hotness from Ignition tiering up decision since this is not relevent for full-codegen compilation. Also make the decision about what tier we are moving to more explicit and visible in --trace-opt. BUG=v8:4280 LOG=N Committed: https://crrev.com/9c6ff183556ebf43a93e64b2111aeaee6fcbd102 Cr-Commit-Position: refs/heads/master@{#36260}

Patch Set 1 #

Patch Set 2 : Fix test failure. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -50 lines) Patch
M src/bailout-reason.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M src/runtime-profiler.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/runtime-profiler.cc View 1 6 chunks +36 lines, -47 lines 0 comments Download
M src/runtime/runtime-test.cc View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 13 (6 generated)
rmcilroy
Michi, PTAL, thanks.
4 years, 7 months ago (2016-05-11 12:05:33 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1969773002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1969773002/1
4 years, 7 months ago (2016-05-11 12:05:42 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_mac_rel_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng/builds/1482) v8_mac_rel_ng_triggered on ...
4 years, 7 months ago (2016-05-11 12:30:51 UTC) #6
Michael Starzinger
LGTM modulo test failures.
4 years, 7 months ago (2016-05-11 13:22:00 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1969773002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1969773002/20001
4 years, 7 months ago (2016-05-16 15:07:11 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-16 15:37:53 UTC) #11
commit-bot: I haz the power
4 years, 7 months ago (2016-05-16 15:39:58 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9c6ff183556ebf43a93e64b2111aeaee6fcbd102
Cr-Commit-Position: refs/heads/master@{#36260}

Powered by Google App Engine
This is Rietveld 408576698