Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 196973002: Disable test/mac/gyptest-objc-gc.py when using Xcode 5.1 (Closed)

Created:
6 years, 9 months ago by sdefresne
Modified:
6 years, 9 months ago
Reviewers:
Mark Mentovai
CC:
gyp-developer_googlegroups.com
Visibility:
Public.

Description

Disable test/mac/gyptest-objc-gc.py when using Xcode 5.1 Xcode 5.1 removed support for garbage collection, and no longer recognize the GCC_ENABLE_OBJC_GC settings, so disable the corresponding test. BUG=gyp:414 R=mark@chromium.org Committed: https://code.google.com/p/gyp/source/detail?r=1868

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -18 lines) Patch
M test/mac/gyptest-objc-gc.py View 2 chunks +24 lines, -18 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
sdefresne
PTAL
6 years, 9 months ago (2014-03-12 09:34:44 UTC) #1
Mark Mentovai
LGTM
6 years, 9 months ago (2014-03-12 13:31:37 UTC) #2
sdefresne
6 years, 9 months ago (2014-03-12 13:40:27 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r1868 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698