Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1969713002:
Mark imported/csswg-test/.../variable-external-font-face-01.html as Flaky on WebKit Linux Leak (Closed)
DescriptionMark imported/csswg-test/.../variable-external-font-face-01.html as Flaky on WebKit Linux Leak
failed unexpectedly (leak detected: ({"numberOfLiveActiveDOMObjects":[2,3],"numberOfLiveResources":[0,1]}))
since
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Leak/builds/19266
BUG=610938, 594309
NOTRY=true
TBR=kojii@chromium.org
Committed: https://crrev.com/66ed2523a395c63121689114bea79759bec051e5
Cr-Commit-Position: refs/heads/master@{#393186}
Patch Set 1 #
Total comments: 1
Patch Set 2 : Flaky leak #Patch Set 3 : Add variable-font-face-02.html #Messages
Total messages: 18 (10 generated)
Description was changed from
==========
Mark imported/csswg-test/.../variable-external-font-face-01.html as Flaky on
WebKit Linux Leak
failed unexpectedly (leak detected:
({"numberOfLiveActiveDOMObjects":[2,3],"numberOfLiveResources":[0,1]}))
since
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Leak/b...
BUG=610938, 594309
==========
to
==========
Mark imported/csswg-test/.../variable-external-font-face-01.html as Flaky on
WebKit Linux Leak
failed unexpectedly (leak detected:
({"numberOfLiveActiveDOMObjects":[2,3],"numberOfLiveResources":[0,1]}))
since
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Leak/b...
BUG=610938, 594309
TBR=kojii@chromium.org
==========
tapted@chromium.org changed reviewers: + kojii@chromium.org
samli@chromium.org changed reviewers: + samli@chromium.org
lgtm
The CQ bit was checked by tapted@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1969713002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1969713002/1
The CQ bit was unchecked by tapted@chromium.org
https://codereview.chromium.org/1969713002/diff/1/third_party/WebKit/LayoutTe... File third_party/WebKit/LayoutTests/LeakExpectations (right): https://codereview.chromium.org/1969713002/diff/1/third_party/WebKit/LayoutTe... third_party/WebKit/LayoutTests/LeakExpectations:152: crbug.com/594309 [ Linux ] imported/csswg-test/vendor-imports/mozilla/mozilla-central-reftests/variables/variable-external-font-face-01.html [ Leak ] hum booted out of CQ since I'm not sure if this should be [ Leak ] or [ Leak Pass ], since it is flaky. Haven't played with this stuff before. There's also the comment at the top "you can ignore the failures and wait for kouhei@ or hajimehoshi@ to maintain this file" - i wonder if that's still current.
Description was changed from
==========
Mark imported/csswg-test/.../variable-external-font-face-01.html as Flaky on
WebKit Linux Leak
failed unexpectedly (leak detected:
({"numberOfLiveActiveDOMObjects":[2,3],"numberOfLiveResources":[0,1]}))
since
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Leak/b...
BUG=610938, 594309
TBR=kojii@chromium.org
==========
to
==========
Mark imported/csswg-test/.../variable-external-font-face-01.html as Flaky on
WebKit Linux Leak
failed unexpectedly (leak detected:
({"numberOfLiveActiveDOMObjects":[2,3],"numberOfLiveResources":[0,1]}))
since
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Leak/b...
BUG=610938, 594309
NOTRY=true
TBR=kojii@chromium.org
==========
added variable-font-face-02.html - it's been flaking too. E.g. https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Leak/b... CQing now
The CQ bit was checked by tapted@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from samli@chromium.org Link to the patchset: https://codereview.chromium.org/1969713002/#ps40001 (title: "Add variable-font-face-02.html")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1969713002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1969713002/40001
Message was sent while issue was closed.
Description was changed from
==========
Mark imported/csswg-test/.../variable-external-font-face-01.html as Flaky on
WebKit Linux Leak
failed unexpectedly (leak detected:
({"numberOfLiveActiveDOMObjects":[2,3],"numberOfLiveResources":[0,1]}))
since
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Leak/b...
BUG=610938, 594309
NOTRY=true
TBR=kojii@chromium.org
==========
to
==========
Mark imported/csswg-test/.../variable-external-font-face-01.html as Flaky on
WebKit Linux Leak
failed unexpectedly (leak detected:
({"numberOfLiveActiveDOMObjects":[2,3],"numberOfLiveResources":[0,1]}))
since
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Leak/b...
BUG=610938, 594309
NOTRY=true
TBR=kojii@chromium.org
==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from
==========
Mark imported/csswg-test/.../variable-external-font-face-01.html as Flaky on
WebKit Linux Leak
failed unexpectedly (leak detected:
({"numberOfLiveActiveDOMObjects":[2,3],"numberOfLiveResources":[0,1]}))
since
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Leak/b...
BUG=610938, 594309
NOTRY=true
TBR=kojii@chromium.org
==========
to
==========
Mark imported/csswg-test/.../variable-external-font-face-01.html as Flaky on
WebKit Linux Leak
failed unexpectedly (leak detected:
({"numberOfLiveActiveDOMObjects":[2,3],"numberOfLiveResources":[0,1]}))
since
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Leak/b...
BUG=610938, 594309
NOTRY=true
TBR=kojii@chromium.org
Committed: https://crrev.com/66ed2523a395c63121689114bea79759bec051e5
Cr-Commit-Position: refs/heads/master@{#393186}
==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/66ed2523a395c63121689114bea79759bec051e5 Cr-Commit-Position: refs/heads/master@{#393186}
Message was sent while issue was closed.
lgtm, thank you! |
