Move dependency on env_vars.h to breakpad client

Move dependency on env_vars.h to breakpad client

BUG=247431
R=marja@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=212603

[jochen (gone - plz use gerrit), 2013-07-19 07:40:31]

plz review

[marja, 2013-07-19 08:20:32]

lgtm

https://codereview.chromium.org/19697015/diff/3001/chrome/app/chrome_breakpad...
File chrome/app/chrome_breakpad_client.cc (right):

https://codereview.chromium.org/19697015/diff/3001/chrome/app/chrome_breakpad...
chrome/app/chrome_breakpad_client.cc:91: !env->HasVar(env_vars::kRestartInfo)) {
Nit: no { } for one-line bodies, even if the "if" is several lines.

[jochen (gone - plz use gerrit), 2013-07-19 08:23:51]

https://codereview.chromium.org/19697015/diff/3001/chrome/app/chrome_breakpad...
File chrome/app/chrome_breakpad_client.cc (right):

https://codereview.chromium.org/19697015/diff/3001/chrome/app/chrome_breakpad...
chrome/app/chrome_breakpad_client.cc:91: !env->HasVar(env_vars::kRestartInfo)) {
On 2013/07/19 08:20:33, marja wrote:
> Nit: no { } for one-line bodies, even if the "if" is several lines.

where's that rule from?

[marja, 2013-07-19 08:31:56]

https://codereview.chromium.org/19697015/diff/3001/chrome/app/chrome_breakpad...
File chrome/app/chrome_breakpad_client.cc (right):

https://codereview.chromium.org/19697015/diff/3001/chrome/app/chrome_breakpad...
chrome/app/chrome_breakpad_client.cc:91: !env->HasVar(env_vars::kRestartInfo)) {
On 2013/07/19 08:23:51, jochen wrote:
> On 2013/07/19 08:20:33, marja wrote:
> > Nit: no { } for one-line bodies, even if the "if" is several lines.
> 
> where's that rule from?

Hmmh! I might be misinformed! Atm the style guide says: "In general, curly
braces are not required for single-line statements, but they are allowed if you
like them."

But but.. has it always been like this? I've had reviewers comment several times
that I should remove the { } if the body is one line.

However, pls ignore the nit, it's wrong.

[commit-bot: I haz the power, 2013-07-19 08:52:39]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jochen@chromium.org/19697015/3001

[commit-bot: I haz the power, 2013-07-19 11:33:27]

Retried try job too often on win_rel for step(s) chrome_frame_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2013-07-19 13:39:12]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jochen@chromium.org/19697015/28001

[commit-bot: I haz the power, 2013-07-19 18:13:58]

Change committed as 212603