Change v8_snapshot_toolchain to be a GN build arg.

Change v8_snapshot_toolchain to be a GN build arg.

It is likely that CrOS and other distros will want to be
able to build the v8 snapshot with a custom toolchain.

This CL makes snapshot_toolchain a declared build arg, and
renames it to v8_snapshot_toolchain to minimize the risk
of a name collision.

R=machenbach@chromium.org, jochen@chromium.org
BUG=608596
Committed: https://crrev.com/2ae74af8f405f461d8e44d60b978f940673e46c8
Cr-Commit-Position: refs/heads/master@{#36193}

[Dirk Pranke, 2016-05-11 02:05:15]

Description was changed from

==========
Change v8_snapshot_toolchain to be a GN build arg.

It is likely that CrOS and other distros will want to be
able to build the v8 snapshot with a custom toolchain.

This CL makes snapshot_toolchain a declared build arg, and
renames it to v8_snapshot_toolchain to minimize the risk
of a name collision.

R=machenbach@chromium.org, jochen@chromium.org
BUG=608596
==========

to

==========
Change v8_snapshot_toolchain to be a GN build arg.

It is likely that CrOS and other distros will want to be
able to build the v8 snapshot with a custom toolchain.

This CL makes snapshot_toolchain a declared build arg, and
renames it to v8_snapshot_toolchain to minimize the risk
of a name collision.

R=machenbach@chromium.org, jochen@chromium.org
BUG=608596
==========

[Michael Achenbach, 2016-05-11 07:27:01]

lgtm

[Dirk Pranke, 2016-05-12 05:08:11]

This isn't the full fix, but it's at least part of the fix, so we might as well
land it. 

I'll add thakis's win-from-mac request plus update //v8/BUILD.gn in a follow-up
CL but if we land this now it'll hopefully roll into chromium and unblock the
other CL sooner.

[Dirk Pranke, 2016-05-12 05:08:15]

The CQ bit was checked by dpranke@chromium.org

[commit-bot: I haz the power, 2016-05-12 05:08:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1969693002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1969693002/40001

[commit-bot: I haz the power, 2016-05-12 05:37:17]

Description was changed from

==========
Change v8_snapshot_toolchain to be a GN build arg.

It is likely that CrOS and other distros will want to be
able to build the v8 snapshot with a custom toolchain.

This CL makes snapshot_toolchain a declared build arg, and
renames it to v8_snapshot_toolchain to minimize the risk
of a name collision.

R=machenbach@chromium.org, jochen@chromium.org
BUG=608596
==========

to

==========
Change v8_snapshot_toolchain to be a GN build arg.

It is likely that CrOS and other distros will want to be
able to build the v8 snapshot with a custom toolchain.

This CL makes snapshot_toolchain a declared build arg, and
renames it to v8_snapshot_toolchain to minimize the risk
of a name collision.

R=machenbach@chromium.org, jochen@chromium.org
BUG=608596
==========

[commit-bot: I haz the power, 2016-05-12 05:37:18]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-05-12 05:37:57]

Description was changed from

==========
Change v8_snapshot_toolchain to be a GN build arg.

It is likely that CrOS and other distros will want to be
able to build the v8 snapshot with a custom toolchain.

This CL makes snapshot_toolchain a declared build arg, and
renames it to v8_snapshot_toolchain to minimize the risk
of a name collision.

R=machenbach@chromium.org, jochen@chromium.org
BUG=608596
==========

to

==========
Change v8_snapshot_toolchain to be a GN build arg.

It is likely that CrOS and other distros will want to be
able to build the v8 snapshot with a custom toolchain.

This CL makes snapshot_toolchain a declared build arg, and
renames it to v8_snapshot_toolchain to minimize the risk
of a name collision.

R=machenbach@chromium.org, jochen@chromium.org
BUG=608596

Committed: https://crrev.com/2ae74af8f405f461d8e44d60b978f940673e46c8
Cr-Commit-Position: refs/heads/master@{#36193}
==========

[commit-bot: I haz the power, 2016-05-12 05:37:59]

Patchset 3 (id:??) landed as
https://crrev.com/2ae74af8f405f461d8e44d60b978f940673e46c8
Cr-Commit-Position: refs/heads/master@{#36193}

[Michael Achenbach, 2016-05-12 08:27:25]

A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/1975713002/ by machenbach@chromium.org.

The reason for reverting is: Blocks the roll:
https://codereview.chromium.org/1974733002/

Breaks:
https://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy....

[Dirk Pranke, 2016-05-12 15:54:54]

On 2016/05/12 08:27:25, Michael Achenbach wrote:
> A revert of this CL (patchset #3 id:40001) has been created in
> https://codereview.chromium.org/1975713002/ by mailto:machenbach@chromium.org.
> 
> The reason for reverting is: Blocks the roll:
> https://codereview.chromium.org/1974733002/
> 
> Breaks:
>
https://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy....

Argh, looks like we need to change chromite to set use_sysroot=false . Thanks
for reverting.