Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Unified Diff: tools/metrics/histograms/histograms.xml

Issue 1969663003: [HttpCache] Measure causes for cache validation requests (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Treat unconditionalizable requests separately Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
« no previous file with comments | « net/http/http_cache_transaction.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index 9087c187d2f21e8c7d6daa12ec102e82489f20dc..0178cbf0c87748b834de259e11a6b71a6269dd44 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -17481,6 +17481,15 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
</summary>
</histogram>
+<histogram name="HttpCache.CantConditionalizeCause"
+ enum="HttpCacheValidationCause">
+ <owner>jkarlin@chromium.org</owner>
+ <summary>
+ For each request that results in an unconditionalizable network request, the
+ cause for the request.
+ </summary>
+</histogram>
+
<histogram name="HttpCache.EntryLockWait" units="ms">
<owner>jkarlin@chromium.org</owner>
<owner>gavinp@chromium.org</owner>
@@ -17533,6 +17542,11 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
<summary>Net error results from restartable cache read errors.</summary>
</histogram>
+<histogram name="HttpCache.ValidationCause" enum="HttpCacheValidationCause">
+ <owner>jkarlin@chromium.org</owner>
+ <summary>For each validation attempt, the cause for the validation.</summary>
+</histogram>
+
<histogram name="HttpCache.Vary" enum="VaryType">
<obsolete>
Deprecated as of 11/2014.
@@ -74654,6 +74668,14 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
<int value="6" label="CantConditionalize"/>
</enum>
+<enum name="HttpCacheValidationCause" type="int">
+ <int value="0" label="Undefined"/>
+ <int value="1" label="Vary Mismatch"/>
+ <int value="2" label="Validate Flag"/>
+ <int value="3" label="Stale Resource"/>
+ <int value="4" label="Zero Freshness"/>
+</enum>
+
<enum name="HttpHeaderParserEvent" type="int">
<int value="0" label="PARSER_INVOKED"/>
<int value="1" label="HTTP_09_RESPONSE"/>
@@ -89517,6 +89539,7 @@ To add a new entry, add it with any value and run test to compute valid value.
content-length &gt;= 100 bytes."/>
<suffix name="Font" label="Showing cache patterns only for font resources."/>
<affected-histogram name="HttpCache.Pattern"/>
+ <affected-histogram name="HttpCache.ValidationCause"/>
</histogram_suffixes>
<histogram_suffixes name="CacheInstance" separator="." ordering="prefix">
« no previous file with comments | « net/http/http_cache_transaction.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698