Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(680)

Issue 1969623003: Reset context after doing non-Skia GL rendering. (Closed)

Created:
4 years, 7 months ago by Brian Osman
Modified:
4 years, 7 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Reset context after doing non-Skia GL rendering. Fixes nanobench crash in GLInstancedArraysBench BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1969623003 Committed: https://skia.googlesource.com/skia/+/393c2ff0d2db9c5d84e6ed660ea9f546f438cb47

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M bench/GLBench.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1969623003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1969623003/1
4 years, 7 months ago (2016-05-11 15:18:04 UTC) #3
Brian Osman
4 years, 7 months ago (2016-05-11 15:18:20 UTC) #5
robertphillips
lgtm
4 years, 7 months ago (2016-05-11 15:27:39 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-11 15:38:16 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1969623003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1969623003/1
4 years, 7 months ago (2016-05-11 15:49:05 UTC) #10
commit-bot: I haz the power
4 years, 7 months ago (2016-05-11 15:50:01 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/393c2ff0d2db9c5d84e6ed660ea9f546f438cb47

Powered by Google App Engine
This is Rietveld 408576698