Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Issue 1969583002: Revert of Add support for origin trials in workers. (Closed)

Created:
4 years, 7 months ago by Marijn Kruisselbrink
Modified:
4 years, 7 months ago
CC:
blink-reviews, blink-reviews-bindings_chromium.org, blink-reviews-dom_chromium.org, blink-worker-reviews_chromium.org, chasej+watch_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, falken, horo+watch_chromium.org, kinuko+worker_chromium.org, rwlbuis, sof
Base URL:
https://chromium.googlesource.com/chromium/src.git@trial-token-in-header-blink-document
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add support for origin trials in workers. (patchset #10 id:200001 of https://codereview.chromium.org/1828063002/ ) Reason for revert: http/tests/origin_trials/sample-api-workers.html seems to randomly timeout sometimes, not sure yet if it's just slow or if something is actually flaky/wrong Original issue's description: > Add support for origin trials in workers. > > This adds support for origin trials in workers (dedicated, shared > and service workers). It does so by adding a list of tokens to > WorkerThreadStartupData. That list is filled using the response headers > for shared and service workers, and filled with the documents tokens > for dedicated workers. > > BUG=582063 > BUG=582195 > BUG=582197 > > Committed: https://crrev.com/de1993ee636b9c8a2ca0f1a817ff3d3ca5c88a6d > Cr-Commit-Position: refs/heads/master@{#392661} TBR=haraken@chromium.org,iclelland@chromium.org,kinuko@chromium.org,rbyers@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=582063 Committed: https://crrev.com/267bff8b11e4e4f1fabebcaa14acebd5909a266d Cr-Commit-Position: refs/heads/master@{#392741}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -171 lines) Patch
D third_party/WebKit/LayoutTests/http/tests/origin_trials/resources/disabled-worker.js View 1 chunk +0 lines, -8 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/origin_trials/resources/enabled-worker.js View 1 chunk +0 lines, -8 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/origin_trials/resources/origin_trials.js View 2 chunks +0 lines, -4 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/origin_trials/resources/sample-api-enabled-worker.php View 1 chunk +0 lines, -14 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/origin_trials/sample-api-workers.html View 1 chunk +0 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/bindings/templates/utilities.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestObject.cpp View 12 chunks +12 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/core/core.gypi View 2 chunks +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/origin_trials/OriginTrialContext.h View 2 chunks +1 line, -16 lines 0 comments Download
M third_party/WebKit/Source/core/origin_trials/OriginTrialContext.cpp View 2 chunks +7 lines, -27 lines 0 comments Download
D third_party/WebKit/Source/core/origin_trials/testing/WorkerInternalsFrobulate.h View 1 chunk +0 lines, -22 lines 0 comments Download
D third_party/WebKit/Source/core/origin_trials/testing/WorkerInternalsFrobulate.idl View 1 chunk +0 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/workers/DedicatedWorkerGlobalScope.cpp View 2 chunks +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/workers/InProcessWorkerMessagingProxy.cpp View 2 chunks +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/workers/SharedWorkerGlobalScope.cpp View 2 chunks +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/workers/WorkerScriptLoader.h View 2 chunks +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/workers/WorkerScriptLoader.cpp View 2 chunks +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/workers/WorkerThreadStartupData.h View 3 chunks +3 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/workers/WorkerThreadStartupData.cpp View 2 chunks +6 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/core/workers/WorkerThreadTestHelper.h View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/compositorworker/CompositorWorkerThreadTest.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerGlobalScope.cpp View 2 chunks +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/WebEmbeddedWorkerImpl.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/web/WebSharedWorkerImpl.cpp View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Marijn Kruisselbrink
Created Revert of Add support for origin trials in workers.
4 years, 7 months ago (2016-05-10 22:07:27 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1969583002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1969583002/1
4 years, 7 months ago (2016-05-10 22:08:01 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-10 22:09:00 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/267bff8b11e4e4f1fabebcaa14acebd5909a266d Cr-Commit-Position: refs/heads/master@{#392741}
4 years, 7 months ago (2016-05-10 22:10:29 UTC) #5
haraken
4 years, 7 months ago (2016-05-10 23:22:56 UTC) #6
Message was sent while issue was closed.
LGTM to revert

Powered by Google App Engine
This is Rietveld 408576698