Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Issue 1969573002: Revert of Roll flac 2c4b86af:2d224742 (Closed)

Created:
4 years, 7 months ago by hans
Modified:
4 years, 7 months ago
Reviewers:
Nico, felt
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Roll flac 2c4b86af:2d224742 (patchset #2 id:20001 of https://codereview.chromium.org/1965553004/ ) Reason for revert: Broke e.g. https://build.chromium.org/p/chromium.fyi/builders/CrWinClang/builds/8652/steps/compile/logs/stdio Reverting while investigating. Original issue's description: > Roll flac 2c4b86af:2d224742 > > 9fc1ca46 Update flac URL in README.chromium. > 59c0c55a Update FLAC to 1.3.1 > 2d224742 README.chromium: restore the Name field > > BUG=610125 > > Committed: https://crrev.com/607364754c497842182a9c776e492564689d8d4f > Cr-Commit-Position: refs/heads/master@{#392693} TBR=felt@chromium.org,thakis@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=610125 Committed: https://crrev.com/6e971665cbbc1d270560da93b3736bf9907ce88f Cr-Commit-Position: refs/heads/master@{#392736}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
hans
Created Revert of Roll flac 2c4b86af:2d224742
4 years, 7 months ago (2016-05-10 21:54:51 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1969573002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1969573002/1
4 years, 7 months ago (2016-05-10 21:55:20 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-10 21:55:57 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/6e971665cbbc1d270560da93b3736bf9907ce88f Cr-Commit-Position: refs/heads/master@{#392736}
4 years, 7 months ago (2016-05-10 21:58:16 UTC) #6
felt
4 years, 7 months ago (2016-05-10 21:58:55 UTC) #7
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698