Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(341)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1969563002: Eliminate GrowableTokenStream (Closed)

Created:
4 years, 7 months ago by hausner
Modified:
4 years, 7 months ago
Reviewers:
siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org, Ivan Posva
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Eliminate GrowableTokenStream Eliminate building an intermediate array of tokens in the scanner. Build the compressed TokenStream directly instead. BUG= R=asiva@google.com Committed: https://github.com/dart-lang/sdk/commit/68a606079499f2d09dff54d82683334b44b98dda

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+126 lines, -141 lines) Patch
M runtime/lib/integers.cc View 1 chunk +1 line, -6 lines 0 comments Download
M runtime/vm/object.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/object.cc View 1 2 6 chunks +33 lines, -31 lines 0 comments Download
M runtime/vm/object_test.cc View 1 chunk +1 line, -6 lines 0 comments Download
M runtime/vm/scanner.h View 1 2 6 chunks +14 lines, -15 lines 0 comments Download
M runtime/vm/scanner.cc View 1 2 6 chunks +22 lines, -47 lines 0 comments Download
M runtime/vm/scanner_test.cc View 1 2 20 chunks +53 lines, -33 lines 0 comments Download
M runtime/vm/snapshot_test.cc View 1 2 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
hausner
4 years, 7 months ago (2016-05-10 21:14:00 UTC) #3
siva
lgtm https://chromiumcodereview.appspot.com/1969563002/diff/20001/runtime/vm/object.cc File runtime/vm/object.cc (right): https://chromiumcodereview.appspot.com/1969563002/diff/20001/runtime/vm/object.cc#newcode8479 runtime/vm/object.cc:8479: this->AddIdentToken(*token.literal); isn't AddIdentToken(...) sufficient why this->AddIdentToken(...) ? https://chromiumcodereview.appspot.com/1969563002/diff/20001/runtime/vm/scanner_test.cc ...
4 years, 7 months ago (2016-05-11 20:21:27 UTC) #4
hausner
4 years, 7 months ago (2016-05-11 21:09:49 UTC) #6
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
68a606079499f2d09dff54d82683334b44b98dda (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698