Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issue 1969553003: X87: [crankshaft] Fragmentation-free allocation folding. (Closed)

Created:
4 years, 7 months ago by zhengxing.li
Modified:
4 years, 7 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [crankshaft] Fragmentation-free allocation folding. port 61f5fbbb1926e1ffb672214a043e8c98db0e8af6 (r36133) original commit message: The new allocation folding implementation avoids fragmentation between folded allocation. As a consequence, our heap will always be iterable i.e. we do not have to perform a garbage collection before iterating the heap. BUG= Committed: https://crrev.com/ef778970fd754a5019bb9ad6434958f15ae0de25 Cr-Commit-Position: refs/heads/master@{#36158}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -25 lines) Patch
M src/crankshaft/x87/lithium-codegen-x87.cc View 2 chunks +24 lines, -25 lines 1 comment Download
M src/x87/macro-assembler-x87.h View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
zhengxing.li
PTAL, thanks!
4 years, 7 months ago (2016-05-11 07:14:13 UTC) #2
Weiliang
lgtm
4 years, 7 months ago (2016-05-11 07:42:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1969553003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1969553003/1
4 years, 7 months ago (2016-05-11 07:43:30 UTC) #5
Hannes Payer (out of office)
https://codereview.chromium.org/1969553003/diff/1/src/crankshaft/x87/lithium-codegen-x87.cc File src/crankshaft/x87/lithium-codegen-x87.cc (right): https://codereview.chromium.org/1969553003/diff/1/src/crankshaft/x87/lithium-codegen-x87.cc#newcode5459 src/crankshaft/x87/lithium-codegen-x87.cc:5459: void LCodeGen::DoFastAllocate(LFastAllocate* instr) { Why do you move that ...
4 years, 7 months ago (2016-05-11 07:44:42 UTC) #6
zhengxing.li
On 2016/05/11 07:44:42, Hannes Payer wrote: > https://codereview.chromium.org/1969553003/diff/1/src/crankshaft/x87/lithium-codegen-x87.cc > File src/crankshaft/x87/lithium-codegen-x87.cc (right): > > https://codereview.chromium.org/1969553003/diff/1/src/crankshaft/x87/lithium-codegen-x87.cc#newcode5459 ...
4 years, 7 months ago (2016-05-11 07:48:43 UTC) #7
Hannes Payer (out of office)
lgtm
4 years, 7 months ago (2016-05-11 07:58:19 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-11 08:14:53 UTC) #9
commit-bot: I haz the power
4 years, 7 months ago (2016-05-11 08:15:18 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ef778970fd754a5019bb9ad6434958f15ae0de25
Cr-Commit-Position: refs/heads/master@{#36158}

Powered by Google App Engine
This is Rietveld 408576698