Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Issue 1969543004: unbundle: add GN files for ffmpeg, libevent, libxslt, snappy, and yasm (Closed)

Created:
4 years, 7 months ago by Paweł Hajdan Jr.
Modified:
4 years, 7 months ago
Reviewers:
Dirk Pranke, brettw
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

unbundle: add GN files for ffmpeg, libevent, libxslt, snappy, and yasm BUG=551343 R=brettw@chromium.org, dpranke@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/309f027eb2f538f349876aefb4b9d3311dd1199e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+173 lines, -9 lines) Patch
A build/linux/unbundle/ffmpeg.gn View 1 chunk +30 lines, -0 lines 0 comments Download
A + build/linux/unbundle/libevent.gn View 1 chunk +8 lines, -7 lines 0 comments Download
A + build/linux/unbundle/libxslt.gn View 1 chunk +6 lines, -2 lines 0 comments Download
M build/linux/unbundle/replace_gn_files.py View 1 chunk +5 lines, -0 lines 0 comments Download
A build/linux/unbundle/snappy.gn View 1 chunk +22 lines, -0 lines 0 comments Download
A build/linux/unbundle/yasm.gn View 1 chunk +102 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Paweł Hajdan Jr.
4 years, 7 months ago (2016-05-11 11:05:34 UTC) #2
brettw
lgtm
4 years, 7 months ago (2016-05-11 19:55:10 UTC) #3
Dirk Pranke
lgtm
4 years, 7 months ago (2016-05-12 01:11:48 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/309f027eb2f538f349876aefb4b9d3311dd1199e Cr-Commit-Position: refs/heads/master@{#393207}
4 years, 7 months ago (2016-05-12 08:21:46 UTC) #6
Paweł Hajdan Jr.
4 years, 7 months ago (2016-05-12 08:22:28 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
309f027eb2f538f349876aefb4b9d3311dd1199e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698